Build projects that consume tool shims in pass 2 #61249
Conversation
ghost
added
the
area-infrastructure
| " | ||
| Condition=" '$(TargetOsName)' == 'win' and '$(DotNetBuild)' == 'true' and ('$(DotNetBuildPass)' == '' or '$(DotNetBuildPass)' == '1') " /> | ||
|
|
||
| <!-- These projects requires inputs from x64, x86, and arm64 on Windows - therefore in the VMR, we build them in pass 2 --> |
There was a problem hiding this comment.
Nit, but they only require x64 & x86 assets
There was a problem hiding this comment.
Will fix - thanks.
|
Wait. Why are we going this direction (BP=2) when we were discussing in the issue that we should just not use the live host for those projects? |
Wouldn't we have hosts from two different builds in that case? One live, one restored from, i.e. nuget.org? I'm fine with either approach, I thought BP=2 made it cleaner. |
I believe the thinking was that it doesn't matter all that oftne, and that this already is the case for any tool that doesn't take flow from runtime. They're always shipping n-1. |
Makes sense. I'll rework this. Will open a new PR. |
|
Closing. Will open a new PR with the other approach, proposed in the issue - dotnet/source-build#4944 |
4 participants
Contributes to dotnet/source-build#4944
We need to pack tool shims for all supported platforms which requires these two projects to be built in VMR's build-pass 2.
Verification build (internal): https://dev.azure.com/dnceng/internal/_build/results?buildId=2674425&view=results