Include all required shims when building in VMR #61282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
ViktorHofer
reviewed
Apr 2, 2025
ViktorHofer
reviewed
Apr 2, 2025
ViktorHofer
reviewed
Apr 2, 2025
ViktorHofer
approved these changes
Apr 2, 2025
wtgodbe
reviewed
Apr 2, 2025
| <!-- Use the same NETCore shared framework as repo built against except when building product code in servicing. --> | ||
| <KnownFrameworkReference Update="Microsoft.NETCore.App"> | ||
| <!-- We cannot use live shims when building tool packs in VMR - only package for current arch is available. --> | ||
| <KnownFrameworkReference Update="Microsoft.NETCore.App" Condition=" '$(DotNetBuild)' != 'true' OR '$(PackAsToolShimRuntimeIdentifiers)' == '' "> |
Member
There was a problem hiding this comment.
To confirm, PackAsToolShimRuntimeIdentifiers is usually empty, right? Because we always want to update this, except for in these tool package scenarios in the VMR
Member
Author
There was a problem hiding this comment.
Yes, PackAsToolShimRuntimeIdentifiers is not set (i.e. empty) unless a specific project builds as a tool and needs to pack shims.
wtgodbe
approved these changes
Apr 2, 2025
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
LGTM other than the 1 question
mmitche
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#4944
We don't have all live shims when building in VMR. The fix is to restore shared framework and apphost packs and not use the live ones, as only one architecture is available.