Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 24, 2025

Preloading is enabled by placing <ResourcePreloader /> component in the application. We don't need to disable in the tests explicitly during build.

@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Apr 24, 2025
@maraf maraf self-assigned this Apr 24, 2025
@maraf maraf changed the title [Blazor] Enable preloading in tests [Blazor] Remove build-time disabling of preloading in tests Sep 26, 2025
@maraf maraf marked this pull request as ready for review September 26, 2025 08:53
@maraf maraf requested a review from a team as a code owner September 26, 2025 08:53
@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 08:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes build-time configuration that explicitly disabled Blazor WebAssembly preloading features in test environments. This change aligns with the new approach where preloading is controlled by adding the <ResourcePreloader /> component to the application rather than being disabled globally at build time.

  • Removes WasmPreloadAssets and BlazorCacheBootResources properties set to false
  • Simplifies test configuration by removing unnecessary build-time overrides
  • Maintains existing behavior through component-based control

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Components/test/testassets/Directory.Build.props Removes PropertyGroup blocks that disabled WASM preloading and boot resource caching for test assets
src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj Removes BlazorCacheBootResources=false setting from performance test app
src/Components/WebAssembly/Directory.Build.props Removes PropertyGroup blocks that disabled preloading features for WebAssembly components

@maraf maraf enabled auto-merge (squash) September 26, 2025 08:53
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant