-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add statically-typed support for wrapping JS interop calls as C# delegates #61721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
oroztocil
wants to merge
7
commits into
main
Choose a base branch
from
oroztocil/js-interop-function-object-reference-static
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d3d91da
Add AsFunction extension method to IJSObjectReference
oroztocil 5b2ac84
Add unit tests, improve error handling
oroztocil 7dbebea
Extend support to 8 arguments
oroztocil c4a743d
Fix handling function references on JS side
oroztocil 384285a
Add AsFunction extension methods to IJSObjectReference
oroztocil ba6ec8b
Update test
oroztocil ea51c5f
Add void variants, update tests
oroztocil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
src/JSInterop/Microsoft.JSInterop/test/JSObjectReferenceExtensionsTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics.CodeAnalysis; | ||
using System.Reflection.PortableExecutable; | ||
using System.Text; | ||
using System.Text.Json; | ||
using System.Threading.Tasks; | ||
using Microsoft.JSInterop.Implementation; | ||
using Microsoft.JSInterop.Infrastructure; | ||
|
||
namespace Microsoft.JSInterop.Tests; | ||
|
||
public class JSObjectReferenceExtensionsTest | ||
{ | ||
[Fact] | ||
public void AsFunction_ReturnsFunc_ThatInvokesInterop() | ||
{ | ||
// Arrange | ||
var jsRuntime = new RecordingTestJSRuntime(); | ||
var jsObjectReference = new JSObjectReference(jsRuntime, 1); | ||
|
||
var bytes = Encoding.UTF8.GetBytes(JsonSerializer.Serialize(42)); | ||
var reader = new Utf8JsonReader(bytes); | ||
|
||
// Act | ||
var func = jsObjectReference.AsFunction<int, int>(); | ||
ValueTask<int> task = func(1); | ||
|
||
jsRuntime.EndInvokeJS( | ||
jsRuntime.InvokeCalls[0].AsyncHandle, | ||
/* succeeded: */ true, | ||
ref reader); | ||
|
||
// Assert | ||
Assert.True(task.IsCompleted); | ||
#pragma warning disable xUnit1031 // Do not use blocking task operations in test method | ||
Assert.Equal(42, task.Result); | ||
#pragma warning restore xUnit1031 // Do not use blocking task operations in test method | ||
} | ||
|
||
class RecordingTestJSRuntime : TestJSRuntime | ||
{ | ||
public List<JSInvocationInfo> InvokeCalls { get; set; } = []; | ||
|
||
protected override void BeginInvokeJS(in JSInvocationInfo invocationInfo) | ||
{ | ||
InvokeCalls.Add(invocationInfo); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is guess
ValueTask
(vsTask
) is here for consistency ?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because the other
Invoke*
methods returnValueTask
. TheJSRuntime
method which implements the actual call also returnsValueTask
(although it creates it from a regularTask
, for some reason).