Add PublishInstallerBaseVersion back #61852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces the PublishInstallerBaseVersion property that was accidentally removed, ensuring that installer build assets are published consistently.
- Restores the PublishInstallerBaseVersion property in eng/Common.props
- Sets its default value to match PublishAllBuildsAssetsInThisJob when unset
Comments suppressed due to low confidence (1)
eng/Common.props:50
- [nitpick] The indentation on this line appears inconsistent with the surrounding XML elements. Please adjust it to match the indentation used for similar elements for better readability.
<PublishInstallerBaseVersion Condition="'$(PublishInstallerBaseVersion)' == ''">$(PublishAllBuildsAssetsInThisJob)</PublishInstallerBaseVersion>
mmitche
approved these changes
May 9, 2025
|
Components failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally removed this in #61271
This pull request introduces a small change to the
eng/Common.propsfile. It adds a new property,PublishInstallerBaseVersion, which defaults to the value ofPublishAllBuildsAssetsInThisJobif not explicitly set.