fix(DbContextHealthCheck): propagate OperationCanceledExceptions instead of reporting unhealthy #61883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-healthchecks
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @@aomader. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced May 12, 2025
…ead of reporting unhealthy
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
@BrennanConroy Do you happen to have some time to look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that
OperationCanceledExceptions bubble up theDbContextHealthCheck(in case thecancellationTokenrequested a cancellation) so that they are not incorrectly treated as unhealthy checks, but can instead for example get correctly swallowed by the callers.This goes hand-in-hand with this change to EF Core that ensures that the default health check correctly throws an exception in case of a
cancellationToken-related exception.