Skip to content

Conversation

captainsafia
Copy link
Member

Gives Copilot some help in getting .NET installed in its environment so that it can run the build scripts in each directory.

@captainsafia captainsafia requested review from a team and wtgodbe as code owners May 20, 2025 20:17
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 20, 2025
env:
# prevent GitInfo errors
CI: false
run: ./restore.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally not building - you're confident build.sh doesn't touch the network after this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're confident build.sh doesn't touch the network after this?

I can't answer this with confidence. @wtgodbe Thoughts on this?

We could call ./build.sh here but that takes a while to execute on the ASP.NET Core repo.

Perhaps something we can try and iterate on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installers pull stuff down from the network during the build. Copilot usually doesn't need those, so we could pass -nobuildinstallers here

@wtgodbe wtgodbe merged commit a79c13d into main May 20, 2025
6 of 8 checks passed
@wtgodbe wtgodbe deleted the captainsafia-patch-1 branch May 20, 2025 21:52
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview5 milestone May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants