Skip to content

Don't change Arcade's default of XUnitRunnerVisualStudioVersion #62250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Don't change Arcade's default of XUnitRunnerVisualStudioVersion #62250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49b341e
Don't change Arcade's default of XUnitRunnerVisualStudioVersion
Youssef1313 Jun 4, 2025
fe1bed9
Use net472 for tests
Youssef1313 Jun 4, 2025
9ffa0a5
Fix template tests: all empty templates have `NotFound.razor` page.
ilonatommy Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@
<NuspecBasePath>$(MSBuildProjectDirectory)</NuspecBasePath>

<IncludeSymbols>true</IncludeSymbols>

<DefaultNetFxTargetFramework>net462</DefaultNetFxTargetFramework>
<!-- Current xunit.runner.visualstudio supports net472+/net8.0+ only. So we can't use net462 -->
<DefaultNetFxTargetFramework Condition="'$(IsTestProject)'=='true'">net472</DefaultNetFxTargetFramework>

<CrossgenOutput Condition="'$(DotNetBuildUseMonoRuntime)' == 'true'">false</CrossgenOutput>
</PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@
<XunitAssertVersion>$(XunitVersion)</XunitAssertVersion>
<XunitExtensibilityCoreVersion>$(XunitVersion)</XunitExtensibilityCoreVersion>
<XunitExtensibilityExecutionVersion>$(XunitVersion)</XunitExtensibilityExecutionVersion>
<XUnitRunnerVisualStudioVersion>2.8.2</XUnitRunnerVisualStudioVersion>
<MicrosoftDataSqlClientVersion>5.2.2</MicrosoftDataSqlClientVersion>
<MicrosoftOpenApiVersion>2.0.0-preview.18</MicrosoftOpenApiVersion>
<MicrosoftOpenApiYamlReaderVersion>2.0.0-preview.18</MicrosoftOpenApiYamlReaderVersion>
Expand Down
1 change: 0 additions & 1 deletion ...ectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
"exclude": [
"BlazorWeb-CSharp/Components/Pages/Auth.*",
"BlazorWeb-CSharp/Components/Pages/Counter.*",
"BlazorWeb-CSharp/Components/Pages/NotFound.*",
"BlazorWeb-CSharp/Components/Pages/Weather.*",
"BlazorWeb-CSharp/Components/Layout/NavMenu.*",
"BlazorWeb-CSharp/wwwroot/lib/**",
Expand Down
6 changes: 6 additions & 0 deletions src/ProjectTemplates/test/Templates.Tests/template-baselines.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3211,6 +3211,7 @@
"App.razor",
"_Imports.razor",
"Pages/Home.razor",
"Pages/NotFound.razor",
"Layout/MainLayout.razor",
"Properties/launchSettings.json",
"wwwroot/icon-192.png",
Expand Down Expand Up @@ -3299,6 +3300,7 @@
"_Imports.razor",
"Pages/Authentication.razor",
"Pages/Home.razor",
"Pages/NotFound.razor",
"Layout/MainLayout.razor",
"Layout/LoginDisplay.razor",
"Layout/RedirectToLogin.razor",
Expand Down Expand Up @@ -3390,6 +3392,7 @@
"_Imports.razor",
"Pages/Authentication.razor",
"Pages/Home.razor",
"Pages/NotFound.razor",
"Layout/MainLayout.razor",
"Layout/LoginDisplay.razor",
"Layout/RedirectToLogin.razor",
Expand Down Expand Up @@ -3480,6 +3483,7 @@
"_Imports.razor",
"Pages/Authentication.razor",
"Pages/Home.razor",
"Pages/NotFound.razor",
"Layout/MainLayout.razor",
"Layout/LoginDisplay.razor",
"Layout/RedirectToLogin.razor",
Expand Down Expand Up @@ -3569,6 +3573,7 @@
"App.razor",
"_Imports.razor",
"Pages/Home.razor",
"Pages/NotFound.razor",
"Layout/MainLayout.razor",
"Properties/launchSettings.json",
"wwwroot/icon-192.png",
Expand Down Expand Up @@ -3654,6 +3659,7 @@
"App.razor",
"_Imports.razor",
"Pages/Home.razor",
"Pages/NotFound.razor",
"Layout/MainLayout.razor",
"wwwroot/icon-192.png",
"wwwroot/index.html",
Expand Down
Loading