Skip to content

Pack symbols in SharedFx for libraries we redist from runtime #62429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 23, 2025
Merged

Pack symbols in SharedFx for libraries we redist from runtime #62429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2f07492
Pack symbols in SharedFx for libraries we redist from runtime
wtgodbe Jun 20, 2025
6e28836
Make it a target
wtgodbe Jun 20, 2025
42ec34a
Fix PackageRef
wtgodbe Jun 20, 2025
3731da7
Fix target name
wtgodbe Jun 20, 2025
6897c51
Use dependson
wtgodbe Jun 21, 2025
dff1fb2
Just reference it
wtgodbe Jun 21, 2025
d3125f6
Fixup
wtgodbe Jun 21, 2025
233105d
Unduplicate
wtgodbe Jun 21, 2025
6356266
Fix conditions
wtgodbe Jun 23, 2025
3291251
Exact match
wtgodbe Jun 23, 2025
065552f
Include transitive .pdb's
wtgodbe Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,25 @@
<PartialCompositeAssemblyListPath>PartialCompositeAssemblyListPath.txt</PartialCompositeAssemblyListPath>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Internal.Runtime.AspNetCore.Transport"
Version="$(MicrosoftInternalRuntimeAspNetCoreTransportVersion)"
ExcludeAssets="All"
GeneratePathProperty="true" />
</ItemGroup>

<!-- Explicitly include symbols for libraries we redistribute from runtime -->
<ItemGroup>
<_TransportPdbs Include="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.pdb"
Exclude="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.ni.pdb" />

Check failure on line 46 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj#L46 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj(46,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/home/vsts/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj (46,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 46 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj#L46 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj(46,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/home/vsts/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj (46,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 46 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj#L46 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj(46,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj (46,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 46 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj#L46 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj(46,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj (46,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

<_TransportPdbsWithName Include="@(_TransportPdbs)"
Name="%(Filename)" />

<_SymbolFilesToPackage Include="@(_TransportPdbsWithName)"
Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" />
Copy link

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring this duplicated symbol packaging block into a shared targets or props file to improve maintainability across projects.

Copilot uses AI. Check for mistakes.

</ItemGroup>

<ItemGroup>
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)">
<IncludeAssets>Runtime;Native</IncludeAssets>
Expand Down
19 changes: 19 additions & 0 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,25 @@
<GenerateVSInsertionPackages>true</GenerateVSInsertionPackages>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Internal.Runtime.AspNetCore.Transport"
Version="$(MicrosoftInternalRuntimeAspNetCoreTransportVersion)"
ExcludeAssets="All"
GeneratePathProperty="true" />
</ItemGroup>

<!-- Explicitly include symbols for libraries we redistribute from runtime -->
<ItemGroup>
<_TransportPdbs Include="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.pdb"
Exclude="$(PkgMicrosoft_Internal_Runtime_AspNetCore_Transport)\**\*.ni.pdb" />

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/home/vsts/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/home/vsts/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl x64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/__w/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl x64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/__w/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS x64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS x64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS arm64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS arm64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/Users/runner/work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/mnt/vss/_work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

Check failure on line 63 in src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj#L63 

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj(63,9): error MSB5029: (NETCORE_ENGINEERING_TELEMETRY=Restore) The value "\**\*.ni.pdb" of the "Exclude" attribute in element <ItemGroup> in file "/mnt/vss/_work/1/s/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj (63,9)" is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined and that the project and current working directory are not at the drive root.

<_TransportPdbsWithName Include="@(_TransportPdbs)"
Name="%(Filename)" />

<_SymbolFilesToPackage Include="@(_TransportPdbsWithName)"
Condition="'@(ExternalAspNetCoreAppReference->AnyHaveMetadataValue('Identity', '%(Name)'))' == 'true'" />
Copy link

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring this duplicated symbol packaging block into a shared targets or props file to improve maintainability across projects.

Copilot uses AI. Check for mistakes.

</ItemGroup>

<ItemGroup>
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)">
<IncludeAssets>Runtime;Native</IncludeAssets>
Expand Down
Loading