Skip to content

Replace use of InvokeNew with InvokeConstructor in Blazor JS interop #62588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2025
Merged

Replace use of InvokeNew with InvokeConstructor in Blazor JS interop #62588

merged 4 commits into from
Jul 8, 2025

Conversation

oroztocil
Copy link
Member

@oroztocil oroztocil commented Jul 7, 2025 •
edited
Loading

  • Applies naming changes as per API review
  • Adds missing extension methods overloads for Get/SetValueAsync with custom timeout.
  • Fixes a JSObjectReference.Get/SetValueAsync overload not passing CancellationToken argument properly.

Fixes #62454
Fixes #62455

@github-actions github-actions bot added the area-blazor Includes: Blazor, Razor Components label Jul 7, 2025
@oroztocil oroztocil force-pushed the oroztocil/rename-invoke-new-to-constructor branch from 07f2ee6 to 264cafc Compare July 7, 2025 19:24
@oroztocil oroztocil force-pushed the oroztocil/rename-invoke-new-to-constructor branch from 67adfbd to 61c6f77 Compare July 7, 2025 21:21
@oroztocil oroztocil marked this pull request as ready for review July 7, 2025 21:25
@oroztocil oroztocil requested a review from a team as a code owner July 7, 2025 21:25
lewing
lewing reviewed Jul 7, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jul 7, 2025
Open
3 tasks
@lewing
Copy link
Member

lewing commented Jul 8, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@oroztocil oroztocil enabled auto-merge (squash) July 8, 2025 18:50
@lewing
Copy link
Member

lewing commented Jul 8, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@oroztocil oroztocil merged commit 01c00d2 into main Jul 8, 2025
29 checks passed
@oroztocil oroztocil deleted the oroztocil/rename-invoke-new-to-constructor branch July 8, 2025 22:06
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 8, 2025
@wenz wenz mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewing lewing lewing approved these changes

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

10.0-preview7

Development

Successfully merging this pull request may close these issues.

API proposal for new JS interop infrastructure API proposal for new user-facing JS interop methods

2 participants

@oroztocil @lewing