Skip to content

Log when an enhanced navigation fails #62598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Log when an enhanced navigation fails #62598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f40458c
Added warning when enhanced navigation falls back to full page reload…
dariatiurina Jul 8, 2025
dd58e2b
tests fix
dariatiurina Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Components/Web.JS/src/Services/NavigationEnhancement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ function enhancedNavigationIsEnabledForForm(form: HTMLFormElement): boolean {
function retryEnhancedNavAsFullPageLoad(internalDestinationHref: string) {
// The ? trick here is the same workaround as described in #10839, and without it, the user
// would not be able to use the back button afterwards.
console.warn(`Enhanced navigation failed for destination ${internalDestinationHref}. Falling back to full page load.`);
history.replaceState(null, '', internalDestinationHref + '?');
location.replace(internalDestinationHref);
}
4 changes: 4 additions & 0 deletions src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,10 @@ public void RefreshCanFallBackOnFullPageReload(string renderMode)
Browser.Exists(By.Id("refresh-with-refresh")).Click();
Browser.True(() => IsElementStale(initialRenderIdElement));

//Check if the warning about the fail were logged.
var logs = Browser.GetBrowserLogs(LogLevel.Warning);
Assert.Contains(logs, log => log.Message.Contains("Enhanced navigation failed for destination") && !log.Message.Contains("Error"));

var finalRenderIdElement = Browser.Exists(By.Id("render-id"));
var finalRenderId = -1;
Browser.True(() => int.TryParse(finalRenderIdElement.Text, out finalRenderId));
Expand Down
Loading