Skip to content

Conversation

los93sol
Copy link

@los93sol los93sol commented Jul 8, 2025

QuickGrid: Adds option to disable rendering of filler rows

Description

This pull request add an option to PaginationState to disable rendering of filler rows.

Fixes #57199 #59096

@los93sol los93sol requested a review from a team as a code owner July 8, 2025 14:42
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 8, 2025
@github-actions github-actions bot added the area-blazor Includes: Blazor, Razor Components label Jul 8, 2025
@javiercn
Copy link
Member

javiercn commented Jul 8, 2025

Thank you for the PR.

Unfortunately, as per the referenced issues, we don't plan to take a product change for this, since we don't believe it's the right thing to do.

We intentionally render all rows—even empty ones—to keep the pagination controls from shifting position as users navigate between pages. This approach ensures a stable and predictable layout.

If you want to hide empty rows or change the appearance, you can use CSS to set a fixed table height or hide empty rows as needed. We recommend customizing the UI through CSS rather than changing the framework’s behavior.

@javiercn javiercn closed this Jul 8, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 8, 2025
@los93sol
Copy link
Author

los93sol commented Jul 8, 2025

@javiercn I'm not sure I understand the logic behind this. The existing code had a comment to consider making it an option and the default functionality is maintained so it's not a breaking change and gives the user the option to turn it off. There are scenarios with different UI frameworks where css workarounds for this are non-trivial and a simple boolean flag is much easier for users to opt out of the filler rows being rendered.

@javiercn
Copy link
Member

javiercn commented Jul 9, 2025

@los93sol I see now that you sent this PR as part of #62494.

We apologize for any confusion here. Our request in that other issue was explicitly for separate issues, not pull requests. The process for new features involves having an issue filed for it no matter the size of the change so that we can clearly triage it and asses the change independently of any other changes.

There are scenarios with different UI frameworks where css workarounds for this are non-trivial

Is there any concrete sample that you can provide?

In this particular case we prefer not to add additional options for something that can be achieved through CSS independent of the framework that you are using. For example, using the following snippet:

tr:empty {
// Your styles.
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paginator renders extra empty rows when page isn't full of items

3 participants