Skip to content

[Blazor] Remove obsolete APIs from Components #62755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

[Blazor] Remove obsolete APIs from Components #62755

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
81d19f6
Initial plan
Copilot Jul 16, 2025
57a002d
Remove obsolete APIs from Blazor components
Copilot Jul 16, 2025
6d839b3
Fix PublicAPI changes: Move removed APIs to Unshipped.txt with *REMOV…
Copilot Jul 16, 2025
a1d12ed
Remove additional obsolete APIs from Components.Web
Copilot Jul 16, 2025
6d7ae8c
Remove additional obsolete APIs from Components.WebAssembly
Copilot Jul 16, 2025
ae83527
Fix PublicAPI and test compilation issues with obsolete APIs
Copilot Jul 17, 2025
5542a4d
Fix logout validation logic to handle null HistoryEntryState properly
Copilot Jul 17, 2025
7a9270e
Restore NotifyLocationChanged to PublicAPI.Shipped.txt per review fee…
Copilot Jul 17, 2025
b773e74
Remove NotifyLocationChanged(string, bool) from PublicAPI.Shipped.txt…
Copilot Jul 17, 2025
e0a3d4d
Fix PublicAPI.Shipped.txt files by removing obsolete API entries
Copilot Jul 17, 2025
388e4c3
Restore all PublicAPI.Shipped.txt files to original state and fix nul…
Copilot Jul 17, 2025
b1f3a4d
Fix API analyzer error by removing obsolete JSInteropMethods entry fr…
Copilot Jul 17, 2025
b86f4e4
Undo changes to PublicAPI.Shipped.txt and fix obsolete API entries in…
Copilot Jul 17, 2025
72de494
Restore PublicAPI.Shipped.txt to original state per review feedback
Copilot Jul 18, 2025
5df2b0b
Fix PublicAPI baseline policy violations by adding proper *REMOVED* e…
Copilot Jul 18, 2025
ac7e0aa
Merge branch 'main' into copilot/fix-50548
Copilot Jul 18, 2025
ca2cc12
Fix RS0017 error by removing non-existent ApplyHotReloadDeltas from P…
Copilot Jul 18, 2025
7a915e5
Fix RS0017 error by removing obsolete NotifyLocationChanged method fr…
Copilot Jul 18, 2025
7f6edda
Undo changes to PublicAPI.Shipped.txt per review feedback
Copilot Jul 18, 2025
c587cd6
Fix RS0017 error by adding *REMOVED* entries for both NotifyLocationC…
Copilot Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Components/Components/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,6 @@ Microsoft.AspNetCore.Components.Routing.Router.NotFound.get -> Microsoft.AspNetC
Microsoft.AspNetCore.Components.Routing.Router.NotFound.set -> void
Microsoft.AspNetCore.Components.Routing.Router.OnNavigateAsync.get -> Microsoft.AspNetCore.Components.EventCallback<Microsoft.AspNetCore.Components.Routing.NavigationContext!>
Microsoft.AspNetCore.Components.Routing.Router.OnNavigateAsync.set -> void
Microsoft.AspNetCore.Components.Routing.Router.PreferExactMatches.get -> bool
Microsoft.AspNetCore.Components.Routing.Router.PreferExactMatches.set -> void
Copy link
Member

@javiercn javiercn Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not modify *.Shipped.txt. Modify *.Unshipped.txt and add the *REMOVED* prefix to the API entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7b8994c. Reverted changes to *.Shipped.txt files and moved the removed API entries to *.Unshipped.txt files with the REMOVED prefix as required.

Microsoft.AspNetCore.Components.Routing.Router.Router() -> void
Microsoft.AspNetCore.Components.Routing.Router.SetParametersAsync(Microsoft.AspNetCore.Components.ParameterView parameters) -> System.Threading.Tasks.Task!
Microsoft.AspNetCore.Components.Sections.SectionContent
Expand Down
8 changes: 0 additions & 8 deletions src/Components/Components/src/Routing/Router.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,6 @@ static readonly IReadOnlyDictionary<string, object> _emptyParametersDictionary
/// </summary>
[Parameter] public EventCallback<NavigationContext> OnNavigateAsync { get; set; }

/// <summary>
/// Gets or sets a flag to indicate whether route matching should prefer exact matches
/// over wildcards.
/// <para>This property is obsolete and configuring it does nothing.</para>
/// </summary>
[Obsolete("This property is obsolete and configuring it has no effect.")]
[Parameter] public bool PreferExactMatches { get; set; }

private RouteTable Routes { get; set; }

/// <inheritdoc />
Expand Down
21 changes: 0 additions & 21 deletions src/Components/Forms/src/EditContextDataAnnotationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,6 @@ namespace Microsoft.AspNetCore.Components.Forms;
/// </summary>
public static partial class EditContextDataAnnotationsExtensions
{
/// <summary>
/// Adds DataAnnotations validation support to the <see cref="EditContext"/>.
/// </summary>
/// <param name="editContext">The <see cref="EditContext"/>.</param>
[Obsolete("Use " + nameof(EnableDataAnnotationsValidation) + " instead.")]
public static EditContext AddDataAnnotationsValidation(this EditContext editContext)
{
EnableDataAnnotationsValidation(editContext);
return editContext;
}

/// <summary>
/// Enables DataAnnotations validation support for the <see cref="EditContext"/>.
/// </summary>
/// <param name="editContext">The <see cref="EditContext"/>.</param>
/// <returns>A disposable object whose disposal will remove DataAnnotations validation support from the <see cref="EditContext"/>.</returns>
[Obsolete("This API is obsolete and may be removed in future versions. Use the overload that accepts an IServiceProvider instead.")]
public static IDisposable EnableDataAnnotationsValidation(this EditContext editContext)
{
return new DataAnnotationsEventSubscriptions(editContext, null!);
}
/// <summary>
/// Enables DataAnnotations validation support for the <see cref="EditContext"/>.
/// </summary>
Expand Down
2 changes: 0 additions & 2 deletions src/Components/Forms/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ override Microsoft.AspNetCore.Components.Forms.DataAnnotationsValidator.OnInitia
override Microsoft.AspNetCore.Components.Forms.DataAnnotationsValidator.OnParametersSet() -> void
override Microsoft.AspNetCore.Components.Forms.FieldIdentifier.Equals(object? obj) -> bool
override Microsoft.AspNetCore.Components.Forms.FieldIdentifier.GetHashCode() -> int
static Microsoft.AspNetCore.Components.Forms.EditContextDataAnnotationsExtensions.AddDataAnnotationsValidation(this Microsoft.AspNetCore.Components.Forms.EditContext! editContext) -> Microsoft.AspNetCore.Components.Forms.EditContext!
static Microsoft.AspNetCore.Components.Forms.EditContextDataAnnotationsExtensions.EnableDataAnnotationsValidation(this Microsoft.AspNetCore.Components.Forms.EditContext! editContext) -> System.IDisposable!
static Microsoft.AspNetCore.Components.Forms.EditContextDataAnnotationsExtensions.EnableDataAnnotationsValidation(this Microsoft.AspNetCore.Components.Forms.EditContext! editContext, System.IServiceProvider! serviceProvider) -> System.IDisposable!
static Microsoft.AspNetCore.Components.Forms.FieldIdentifier.Create<TField>(System.Linq.Expressions.Expression<System.Func<TField>!>! accessor) -> Microsoft.AspNetCore.Components.Forms.FieldIdentifier
static readonly Microsoft.AspNetCore.Components.Forms.ValidationRequestedEventArgs.Empty -> Microsoft.AspNetCore.Components.Forms.ValidationRequestedEventArgs!
Expand Down
10 changes: 0 additions & 10 deletions src/Components/Forms/test/EditContextDataAnnotationsExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@ public void CannotUseNullEditContext()
Assert.Equal("editContext", ex.ParamName);
}

[Fact]
public void ObsoleteApiReturnsEditContextForChaining()
{
var editContext = new EditContext(new object());
#pragma warning disable 0618
var returnValue = editContext.AddDataAnnotationsValidation();
#pragma warning restore 0618
Assert.Same(editContext, returnValue);
}

[Fact]
public void GetsValidationMessagesFromDataAnnotations()
{
Expand Down
Loading