Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
46fcb7f
Initial commit for wix5 update
wtgodbe Jul 23, 2025
8ba1613
Syntax error
wtgodbe Jul 23, 2025
61a709f
Update wixproj's
wtgodbe Jul 23, 2025
3e19f3f
Acquire wix sdk
wtgodbe Jul 23, 2025
68871e0
Fix d.b.p/t
wtgodbe Jul 23, 2025
c6351d2
More ordering stuff
wtgodbe Jul 23, 2025
7b55a21
Get rid of superfluous import
wtgodbe Jul 23, 2025
699e324
Another import removed
wtgodbe Jul 24, 2025
381647d
Custom SDK import
wtgodbe Jul 24, 2025
69ddc01
Another double import
wtgodbe Jul 24, 2025
045f463
Fix hint paths
wtgodbe Jul 24, 2025
21e8c19
Who needs extensions?
wtgodbe Jul 24, 2025
f22d06f
Switch target
wtgodbe Jul 24, 2025
7f377c4
Remove dead switch
wtgodbe Jul 24, 2025
55ab66b
A couple StandardDirectory fixes
wtgodbe Jul 25, 2025
7063711
Merge branch 'wtgodbe/Wix5' of https://github.com/dotnet/aspnetcore i…
wtgodbe Jul 25, 2025
343e522
Small fix
wtgodbe Jul 25, 2025
f740bbd
Back to dir
wtgodbe Jul 25, 2025
fee654b
Typo
wtgodbe Jul 25, 2025
7deda65
Formatting
wtgodbe Aug 5, 2025
cfa8ab7
More formatting
wtgodbe Aug 5, 2025
1f28613
No var.
wtgodbe Aug 5, 2025
b8fc724
Platform -> InstallerPlatform
wtgodbe Aug 5, 2025
f43f04d
No StandardDirectory
wtgodbe Aug 5, 2025
484247b
Fixups
wtgodbe Aug 5, 2025
f2d61eb
Remove unneeded compiles
wtgodbe Aug 5, 2025
34a1c5b
Set Scope
wtgodbe Aug 5, 2025
382e24c
Ref
wtgodbe Aug 5, 2025
c1bd159
Modularize it
wtgodbe Aug 6, 2025
bf6489d
Casing
wtgodbe Aug 6, 2025
fd65c7d
No Var for artifactsdir
wtgodbe Aug 6, 2025
058cec6
Set GUID
wtgodbe Aug 6, 2025
ba57e4e
Move the component into the feature
wtgodbe Aug 6, 2025
93beadb
Generate GUIDs for ANCM DepProviders
wtgodbe Aug 6, 2025
0e8e279
Cheeky workaround
wtgodbe Aug 6, 2025
d3fd491
Revert "Cheeky workaround"
wtgodbe Aug 7, 2025
4479321
Some formatting
wtgodbe Aug 11, 2025
e78c655
NoWarn
wtgodbe Aug 11, 2025
d5342d2
Fix nowarn
wtgodbe Aug 11, 2025
5060052
Merge remote-tracking branch 'upstream/main' into wtgodbe/Wix5
wtgodbe Aug 12, 2025
f297441
Suppress StandardDirectory warning
wtgodbe Aug 12, 2025
254ae86
Temporarily disable wixpack generation, see what explodes
wtgodbe Aug 12, 2025
39ac32a
Cleanup for nupkg script
wtgodbe Aug 12, 2025
295818e
Disable wixpack for testing
wtgodbe Aug 12, 2025
a38d854
StandardDir
wtgodbe Aug 12, 2025
9979d19
Wixpack again
wtgodbe Aug 12, 2025
aea3ead
Fix upgrade policy
wtgodbe Aug 12, 2025
3e7a5cf
Temporarily update Arcade
wtgodbe Aug 13, 2025
ce6b30b
Fix prop name
wtgodbe Aug 13, 2025
ef9531e
New params
wtgodbe Aug 13, 2025
e058292
Remove dupes
wtgodbe Aug 13, 2025
1cd8b46
Exclude wxl's
wtgodbe Aug 13, 2025
b53e918
Resolve conflicts
wtgodbe Aug 13, 2025
d91a202
No var.
wtgodbe Aug 13, 2025
3c4c0fa
Split ifs
wtgodbe Aug 13, 2025
d523d45
Set BindName
wtgodbe Aug 14, 2025
6f9cd8d
Resolve conflicts
wtgodbe Aug 14, 2025
d17879f
Manual arcade bump
wtgodbe Aug 15, 2025
416fced
Add payloads
wtgodbe Aug 15, 2025
ac25bc7
Merge branch 'main' into wtgodbe/Wix5
wtgodbe Aug 23, 2025
ef60e85
Rename file
wtgodbe Aug 23, 2025
b04bc07
Update ref
wtgodbe Aug 24, 2025
fc5a2ef
Update theme
wtgodbe Aug 26, 2025
d9515b3
Add files
wtgodbe Aug 26, 2025
ba9701a
Fixup
wtgodbe Aug 26, 2025
da62b97
Shorter name
wtgodbe Aug 27, 2025
67761f3
Try no options
wtgodbe Aug 28, 2025
acc5a6e
Upload unsigned bundle
wtgodbe Aug 29, 2025
924f19f
Revert "Upload unsigned bundle"
wtgodbe Aug 29, 2025
d330209
Revert "Try no options"
wtgodbe Aug 29, 2025
1670598
Revert "Shorter name"
wtgodbe Aug 29, 2025
fcf1b51
Don't rename it
wtgodbe Aug 29, 2025
da99fb6
Try this
wtgodbe Aug 29, 2025
c5206c7
More
wtgodbe Aug 29, 2025
41db66d
Revert "More"
wtgodbe Aug 30, 2025
4b6984e
Revert "Try this"
wtgodbe Aug 30, 2025
d6c0584
Revert "Don't rename it"
wtgodbe Aug 30, 2025
52e5920
Try something
wtgodbe Aug 30, 2025
20a5fb6
Remove default
wtgodbe Aug 30, 2025
8b91969
Use GenerateFiles
wtgodbe Aug 30, 2025
298e31f
Fixup
wtgodbe Aug 30, 2025
bf1f717
Fix extensions
wtgodbe Aug 30, 2025
64bf2a9
UI Improvements
wtgodbe Sep 4, 2025
32ea7a4
Merge remote-tracking branch 'upstream/main' into wtgodbe/Wix5
wtgodbe Sep 4, 2025
0067a3b
More alignment
wtgodbe Sep 4, 2025
d9e176c
A few more
wtgodbe Sep 4, 2025
71246f7
Fixup
wtgodbe Sep 5, 2025
7165a28
UI fixes
wtgodbe Sep 5, 2025
4e41b19
Update aspnetcore runtime bundle
wtgodbe Sep 5, 2025
6c56d81
Update src/Installers/Windows/Wix.targets
wtgodbe Sep 7, 2025
e135d86
No iswin64
wtgodbe Sep 8, 2025
2191f2a
Some feedback
wtgodbe Sep 8, 2025
b254e41
Feedback, KeyPath
wtgodbe Sep 8, 2025
e179a7d
Fixup
wtgodbe Sep 8, 2025
fb627d3
No need for ProductVersion
wtgodbe Sep 8, 2025
73b3644
Update non-english theme files
wtgodbe Sep 9, 2025
b91f2e0
Update bundleproj
wtgodbe Sep 9, 2025
1ecfdb9
Use wix 5 in runtime bundle
wtgodbe Sep 9, 2025
750dbd3
Update Arcade
wtgodbe Sep 9, 2025
c192a73
Stop using WixThemeVariables
wtgodbe Sep 10, 2025
28e7490
Not using hyperlink license anymore
wtgodbe Sep 10, 2025
cff8a92
Some loc stuff
wtgodbe Sep 10, 2025
dde7bcb
X86 & FilesInUse
wtgodbe Sep 16, 2025
684c12b
Sign less
wtgodbe Sep 16, 2025
23ef642
Try new enable conditions
wtgodbe Sep 17, 2025
8c9b389
NOT
wtgodbe Sep 17, 2025
dbbe43a
Fix signing
wtgodbe Sep 17, 2025
9ca6fe6
Feedback
wtgodbe Sep 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .azure/pipelines/ci-unofficial.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ variables:
value: -RuntimeSourceFeed https://ci.dot.net/internal
-RuntimeSourceFeedKey $(dotnetbuilds-internal-container-read-token-base64)
/p:DotNetAssetRootAccessTokenSuffix='$(dotnetbuilds-internal-container-read-token-base64)'
# The code signing doesn't use the aspnet build scripts, so the msbuild parameters have to be passed directly. This
# is awkward but necessary because the eng/common/ build scripts don't add the msbuild properties automatically.
- name: _InternalRuntimeDownloadCodeSignArgs
value: $(_InternalRuntimeDownloadArgs)
/p:DotNetRuntimeSourceFeed=https://ci.dot.net/internal
/p:DotNetRuntimeSourceFeedKey=$(dotnetbuilds-internal-container-read-token-base64)
- group: DotNet-HelixApi-Access
- name: _SignType
value: test
Expand Down
8 changes: 1 addition & 7 deletions src/Installers/Windows/WindowsHostingBundle/ANCM.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@
<!-- We don't care about the results of the searches below. They are conditioned to execute if we've detected IIS.
If IIS is found, the search will execute and the default "disable" value of the relevant variables will be changed, allowing the UI
text to be displayed. All these searches need to execute after all the primary util:RegistrySearch operations for IIS. -->
<util:RegistrySearch Id="InstallResetIISStateSearch" Condition="((IISCoreWebEngineInstalled_x86=1) AND (IISW3SVCInstalled_x86=1)) OR ((IISCoreWebEngineInstalled_x64=1) AND (IISW3SVCInstalled_x64=1))" Variable="InstallResetIISState" Root="HKLM" Key="SOFTWARE\Microsoft\InetStp\Components" Value="CoreWebEngine" Result="value" After="IISW3SVCInstalledSearch_x64" Bitness="always64" />

<util:RegistrySearch Id="InstallNoIISStateSearch" Condition="NOT (((IISCoreWebEngineInstalled_x86=1) AND (IISW3SVCInstalled_x86=1)) OR ((IISCoreWebEngineInstalled_x64=1) AND (IISW3SVCInstalled_x64=1)))" Variable="InstallNoIISState" Root="HKLM" Key="SOFTWARE\Microsoft\InetStp\Components" Value="CoreWebEngine" Result="value" After="IISW3SVCInstalledSearch_x64" Bitness="always64" />

<util:RegistrySearch Id="ModifyResetIISStateSearch" Condition="((IISCoreWebEngineInstalled_x86=1) AND (IISW3SVCInstalled_x86=1)) OR ((IISCoreWebEngineInstalled_x64=1) AND (IISW3SVCInstalled_x64=1))" Variable="ModifyResetIISState" Root="HKLM" Key="SOFTWARE\Microsoft\InetStp\Components" Value="CoreWebEngine" Result="value" After="IISW3SVCInstalledSearch_x64" Bitness="always64" />

<util:RegistrySearch Id="ModifyNoIISStateSearch" Condition="NOT (((IISCoreWebEngineInstalled_x86=1) AND (IISW3SVCInstalled_x86=1)) OR ((IISCoreWebEngineInstalled_x64=1) AND (IISW3SVCInstalled_x64=1)))" Variable="ModifyNoIISState" Root="HKLM" Key="SOFTWARE\Microsoft\InetStp\Components" Value="CoreWebEngine" Result="value" After="IISW3SVCInstalledSearch_x64" Bitness="always64" />
<util:RegistrySearch Id="IISEnabledSearch" Condition="((IISCoreWebEngineInstalled_x86=1) AND (IISW3SVCInstalled_x86=1)) OR ((IISCoreWebEngineInstalled_x64=1) AND (IISW3SVCInstalled_x64=1))" Variable="IISEnabled" Root="HKLM" Key="SOFTWARE\Microsoft\InetStp\Components" Value="CoreWebEngine" Result="value" After="IISW3SVCInstalledSearch_x64" Bitness="always64" />
</Fragment>
</Wix>
5 changes: 1 addition & 4 deletions src/Installers/Windows/WindowsHostingBundle/Bundle.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@

<!-- These variables control the state of conditional UI text elements.
They are disabled by default and enabled based on whether or not we detect that IIS is installed -->
<Variable Name="InstallResetIISState" Value="disable" Type="formatted" />
<Variable Name="InstallNoIISState" Value="disable" Type="formatted" />
<Variable Name="ModifyResetIISState" Value="disable" Type="formatted" />
<Variable Name="ModifyNoIISState" Value="disable" Type="formatted" />
<Variable Name="IISEnabled" Value="0" Type="numeric" />

<Chain ParallelCache="yes">
<MsiPackage SourceFile="$(HostOptions.TargetPath)">
Expand Down
8 changes: 4 additions & 4 deletions src/Installers/Windows/WindowsHostingBundle/bundle.thm
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
<Page Name="Install">
<Label Name="WelcomeHeader" X="148" Y="80" Width="-12" Height="32" FontId="PageHeaderFont" HexStyle="000000">#(loc.Welcome)</Label>

<Hypertext X="148" Y="120" Width="-12" Height="44" FontId="DefaultFont" Name="InstallResetIIS" HideWhenDisabled="yes">#(loc.InstallResetIIS)</Hypertext>
<Hypertext X="148" Y="120" Width="-12" Height="44" FontId="DefaultFont" Name="InstallNoIIS" HideWhenDisabled="yes">#(loc.InstallNoIIS)</Hypertext>
<Hypertext X="148" Y="120" Width="-12" Height="44" FontId="DefaultFont" Name="InstallResetIIS" EnableCondition="IISEnabled" HideWhenDisabled="yes">#(loc.InstallResetIIS)</Hypertext>
<Hypertext X="148" Y="120" Width="-12" Height="44" FontId="DefaultFont" Name="InstallNoIIS" EnableCondition="NOT IISEnabled" HideWhenDisabled="yes">#(loc.InstallNoIIS)</Hypertext>

<!-- Align the label with the top of the logo on the left. -->
<Label Name="LicenseTermsAndPolicies" X="148" Y="288" Width="-12" Height="32" FontId="DefaultFont" HexStyle="000000">#(loc.LicenseAssent)</Label>
Expand Down Expand Up @@ -59,8 +59,8 @@
<Page Name="Modify">
<Label Name="ModifyHeader" X="148" Y="80" Width="-12" Height="32" FontId="PageHeaderFont" DisablePrefix="yes">#(loc.ModifyHeader)</Label>

<Label Name="ModifyTextIIS" X="148" Y="124" Width="-12" Height="-48" FontId="DefaultFont" HexStyle="00000000" DisablePrefix="yes">#(loc.ModifyResetIIS)</Label>
<Label Name="ModifyTextNoIIS" X="148" Y="124" Width="-12" Height="-48" FontId="DefaultFont" HexStyle="00000000" DisablePrefix="yes">#(loc.ModifyNoIIS)</Label>
<Hypertext Name="ModifyTextIIS" X="148" Y="124" Width="-12" Height="-48" FontId="DefaultFont" HexStyle="00000000" DisablePrefix="yes" EnableCondition="IISEnabled" HideWhenDisabled="yes">#(loc.ModifyResetIIS)</Hypertext>
<Hypertext Name="ModifyTextNoIIS" X="148" Y="124" Width="-12" Height="-48" FontId="DefaultFont" HexStyle="00000000" DisablePrefix="yes" EnableCondition="IISEnabled" HideWhenDisabled="yes">#(loc.ModifyNoIIS)</Hypertext>

<Button Name="RepairButton" X="-236" Y="-12" Width="100" Height="24" TabStop="yes" FontId="DefaultFont" HideWhenDisabled="yes">#(loc.ModifyRepairButton)</Button>
<Button Name="UninstallButton" X="-124" Y="-12" Width="100" Height="24" TabStop="yes" FontId="DefaultFont">#(loc.ModifyUninstallButton)</Button>
Expand Down