Skip to content

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 30, 2025

P7 backport of #62585 - unblocks the build. https://learn.microsoft.com/en-us/windows/arm/arm64x-build#building-an-arm64x-pure-forwarder-dll doesn't work out of the box currently

@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 12:58
@wtgodbe wtgodbe requested a review from a team as a code owner July 30, 2025 12:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a workaround for a linker bug affecting ARM64X pure forwarders in the ASP.NET Core Module setup. It's a backport from the main branch to the release/10.0-preview7 branch to unblock the build process.

  • Adds /FORCE:UNRESOLVED flag to ARM64X link commands to bypass linker errors
  • Configures the build process to continue on errors and ignore standard error warnings
  • Forces successful exit from the build script regardless of linker warnings

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
build.proj Adds error handling attributes to the Exec command to continue on linker errors
build.cmd Adds /FORCE:UNRESOLVED flag to both ARM64X link commands
all.cmd Forces successful exit with exit /b 0 to prevent build failures

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 30, 2025
@wtgodbe wtgodbe merged commit 0e82a53 into release/10.0-preview7 Jul 30, 2025
23 of 29 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/arm64p7 branch July 30, 2025 13:53
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants