Added string arrays to simple binding #63072
Merged
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StickFun
requested review from
BrennanConroy,
captainsafia and
halter73
as code owners
github-actions
bot
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
captainsafia
added
area-minimal
captainsafia
reviewed
Aug 3, 2025
captainsafia
added
the
pr: pending author input
|
Added unit test for handling string array |
captainsafia
reviewed
Aug 4, 2025
| metadata.Name == "formValues") as ParameterBindingMetadata; | ||
|
|
||
| Assert.NotNull(parameterBindingMetadata); | ||
| Assert.Equal(typeof(string[]), parameterBindingMetadata.ParameterInfo.ParameterType); |
There was a problem hiding this comment.
Can we update the test to send a payload in the HTTP context and verify that context.Items["form"] is populated correctly?
captainsafia
reviewed
Aug 7, 2025
|
|
||
| await requestDelegate(httpContext); | ||
|
|
||
| Assert.Equal(new StringValues(new[] { "1", "2", "3" }), httpContext.Items["form"]!); |
There was a problem hiding this comment.
Suggested change
| Assert.Equal(new StringValues(new[] { "1", "2", "3" }), httpContext.Items["form"]!); | |
| var parameterBindingMetadata = factoryResult.EndpointMetadata | |
| .FirstOrDefault(e => e is ParameterBindingMetadata metadata && | |
| metadata.Name == "formValues") as ParameterBindingMetadata; | |
| Assert.NotNull(parameterBindingMetadata); | |
| Assert.Equal(typeof(string[]), parameterBindingMetadata.ParameterInfo.ParameterType); | |
| Assert.Equal(new StringValues(new[] { "1", "2", "3" }), httpContext.Items["form"]!); |
There was a problem hiding this comment.
Commited suggestion
3 tasks
captainsafia
approved these changes
Aug 7, 2025
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
@captainsafia, do I need to do something else to merge this pull-request? |
|
/azp run |
dotnet-policy-service
bot
removed
the
pending-ci-rerun
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added string arrays to simple binding
Description
Fixed condition for using a string array with simple binding.
Fixes #62326