[OpenApi] Test schema reference validity #63095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
martincostello
added
feature-openapi
area-minimal
1 task
dotnet-policy-service
bot
added
the
community-contribution
- Validate OpenAPI documents with Microsoft.OpenApi. - Exclude HTTP QUERY endpoints. - Fix incorrect parameter casing. Relates to dotnet#63090.
Add integration test for invalid OpenAPI schema references. Relates to dotnet#63090.
martincostello
force-pushed
the
gh-63090-validate-schema-references
branch
from
06ffc01 to
502f8c7
Compare
Refactor to use `OpenApiVisitorBase` and `OpenApiWalker` to recursively validate the entire OpenAPI document.
- Fix typo. - Improve reported path. - Find circular references.
Report circular references as an error, rather than throwing an exception.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test schema reference validity
Add integration test for invalid OpenAPI schema references.
Description
Add a draft of a way to test whether OpenAPI schema references are invalid which builds on top of #63092.
The test fails as it reveals the two issues described in #63090.
Will separately open a feature request for Microsoft.OpenApi to have this built-in to the validation rulesets.microsoft/OpenAPI.NET#2453 and microsoft/OpenAPI.NET#2459