Add aria-hidden attribute to spacers #63126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances accessibility for the Blazor Virtualize component by adding aria-hidden="true" attributes to spacer elements, preventing screen readers from announcing these purely visual layout elements to users.
- Added
aria-hidden="true"attribute to both top and bottom spacer elements in theVirtualizecomponent - Updated E2E tests to verify the accessibility attributes are correctly applied
- Ensures spacer elements are hidden from assistive technologies while maintaining visual layout functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Components/Web/src/Virtualization/Virtualize.cs | Added aria-hidden="true" attributes to top and bottom spacer elements and adjusted attribute indices |
| src/Components/test/E2ETest/Tests/VirtualizationTest.cs | Added assertions to verify spacer elements have the aria-hidden="true" attribute in multiple test scenarios |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
javiercn
approved these changes
Aug 5, 2025
ilonatommy
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aria-hidden attribute to spacers
Description
This pull request improves accessibility for the virtualization spacers in the Blazor
Virtualizecomponent by marking them as hidden from assistive technologies and updating related tests to verify this behavior.Changes:
aria-hidden="true"attribute to both top and bottom spacer elements rendered by theVirtualizecomponent to ensure they are ignored by screen readers.VirtualizationTest.csto assert that the spacer elements have thearia-hidden="true"attribute, ensuring the accessibility change is correctly applied.Fixes #62989