-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix ErrorBoundary not rendering ErrorContent when multiple exceptions occur #63145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
13
commits into
main
Choose a base branch
from
copilot/fix-39814
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,659
−3
Draft
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f064c5d
Initial plan
Copilot 9afdff0
Add test case for ErrorBoundary with two different exceptions
Copilot 8d2daa1
Fix ErrorBoundary rendering when multiple exceptions occur
Copilot 99df447
Update test component to match original problem statement with async …
Copilot 6d4016c
Fix ErrorBoundary not rendering ErrorContent when multiple exceptions…
Copilot 99d37be
Add unit test for ErrorBoundary multiple exceptions scenario
Copilot 6a19315
Add comprehensive unit tests for ComponentBase lifecycle async patterns
Copilot 997ac50
Replace compiler workaround with pragma directives for CS1998 warnings
Copilot ced822a
Add Task.FromException tests for ComponentBase lifecycle methods
Copilot af494c9
Add StateHasChanged tracking tests for ComponentBase lifecycle methods
Copilot db09c6b
Add ErrorBoundary tests for ComponentBase lifecycle methods
Copilot ed320b0
Update ComponentWithMultipleExceptions to extend ComponentBase and us…
Copilot ab15a86
Use ErrorBoundaryBase directly for MultipleExceptionsErrorBoundary te…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/Components/test/testassets/BasicTestApp/ErrorBoundaryTest/ComponentWithTwoErrors.razor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
@{ | ||
throw new Exception("error2"); | ||
} | ||
|
||
@code | ||
{ | ||
protected override async Task OnInitializedAsync() | ||
{ | ||
await Task.Yield(); // Make it actually async | ||
throw new Exception("error"); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot This is not the fix.
Check ComponentBase.cs and ComponentBase.cs tests. Author some unit tests to check the behavior of OnInitialized, OnInitializedAsync, OnParametersSet and OnParametersSetAsync.
Take into account all the states a Task returning method can be in. Namely:
If there are tests for some of these, don't add extra tests, but if there are missing tests for the cases above, add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the Renderer.cs changes and added comprehensive unit tests for ComponentBase lifecycle methods covering all the async patterns you mentioned. All tests are passing, indicating the current behavior handles these scenarios correctly.
I've added tests for:
The multiple exceptions test case I added also passes, suggesting the current ComponentBase behavior is working as expected. Could you provide more guidance on what specific issue I should be looking for in the ComponentBase behavior? Commit 6a19315.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep track of all the times StateHasChanged gets called. You can do so probably by putting something on
BuildRenderTree
for the component.When you have those set of tests, replicate the same set of tests but wrapping them inside an ErrorBoundary. You should validate the rendered contents of the error boundary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added comprehensive StateHasChanged tracking tests for ComponentBase lifecycle methods by modifying the TestComponent to count BuildRenderTree calls. The tests cover all the async patterns you mentioned:
Each test verifies the exact number of StateHasChanged calls (BuildRenderTree invocations) that occur in different scenarios. I'm now working on the corresponding ErrorBoundary tests that validate rendered contents as you requested. Commit af494c9.