Skip to content

Fix OpenAPI schema generation for FileContentResult to use binary format #63180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix OpenAPI schema generation for FileContentResult to use binary format #63180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a127105
Fix OpenAPI schema generation for FileContentResult to use binary format
Aug 7, 2025
c4b08d2
Update src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs
shethaadit Aug 8, 2025
aa4220f
More changes.
Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@
TransformSchemaNode = (context, schema) =>
{
var type = context.TypeInfo.Type;
// Fix up schemas generated for IFormFile, IFormFileCollection, Stream, and PipeReader
// Fix up schemas generated for IFormFile, IFormFileCollection, Stream, PipeReader, and FileContentResult
// that appear as properties within complex types.
if (type == typeof(IFormFile) || type == typeof(Stream) || type == typeof(PipeReader))
if (type == typeof(IFormFile) || type == typeof(Stream) || type == typeof(PipeReader) || type == typeof(FileContentResult))

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl ARM64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl ARM)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS arm64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 63 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L63 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(63,117): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)
{
schema = new JsonObject
{
[OpenApiSchemaKeywords.TypeKeyword] = "string",
[OpenApiSchemaKeywords.FormatKeyword] = "binary",
[OpenApiConstants.SchemaId] = "IFormFile"
[OpenApiConstants.SchemaId] = type == typeof(FileContentResult) ? "FileContentResult" : "IFormFile"

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl ARM64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl ARM)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux Musl x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: Linux ARM)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Build: macOS arm64)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 69 in src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs#L69 

src/OpenApi/src/Services/Schemas/OpenApiSchemaService.cs(69,66): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'FileContentResult' could not be found (are you missing a using directive or an assembly reference?)
};
}
else if (type == typeof(IFormFileCollection))
Expand Down
Loading