-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Blazor] Fix JSInitializer URL computation for base URLs with query parameters #63185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: maraf <[email protected]>
Copilot
AI
changed the title
[WIP] [Blazor] Incorrectly computed URL for JSInitializers without base URL
Fix JSInitializer URL computation for base URLs with query parameters
Aug 8, 2025
Copilot finished work on behalf of
maraf
August 8, 2025 12:08
javiercn
approved these changes
Aug 8, 2025
javiercn
reviewed
Aug 8, 2025
…functionality Co-authored-by: javiercn <[email protected]>
Copilot finished work on behalf of
javiercn
August 8, 2025 13:44
3 tasks
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a URL resolution bug in the JSInitializer's adjustPath function where string concatenation was creating malformed URLs when the document base URI contained query parameters or other URL components.
Key changes:
- Replaced string concatenation with the URL constructor for proper URL resolution
- Aligned implementation with the pattern used in MonoPlatform.ts
- Added comprehensive test coverage for various URL scenarios
javiercn
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSInitializer
adjustPathfunction was using string concatenation to build URLs, which created malformed URLs when the document base URI contained query parameters or other URL components.Problem:
When
document.baseURIishttp://domain?a=x, the string concatenation approach would create:This is a malformed URL with the path incorrectly placed after the query string.
Solution:
Replace string concatenation with the URL constructor, following the same pattern used in
MonoPlatform.ts:Result:
The same scenario now correctly produces:
This change ensures proper URL resolution according to web standards, where query parameters and fragments in the base URL are handled correctly when resolving relative paths.
Added comprehensive tests covering various URL scenarios including query parameters, fragments, trailing slashes, and subdirectories.
Fixes #63184.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.