Skip to content

Send Keep-Alive Ping Immediately When Previous Ping Is Overdue #63195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025
Merged

Send Keep-Alive Ping Immediately When Previous Ping Is Overdue #63195

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f902de
Send Keep-Alive ping immediately
ReaganYuan Aug 8, 2025
7a67104
Fix logic
ReaganYuan Aug 12, 2025
d20b04b
PR comments
ReaganYuan Aug 15, 2025
2f7b4ad
Apply suggestions from code review
BrennanConroy Aug 15, 2025
3d1a760
Apply suggestions from code review
BrennanConroy Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/SignalR/clients/ts/signalr/src/HubConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,12 @@ export class HubConnection {
{
let nextPing = this._nextKeepAlive - new Date().getTime();
if (nextPing < 0) {
nextPing = 0;
if (this._connectionState === HubConnectionState.Connected) {
this._sendMessage(this._cachedPingMessage).catch((e) => {
this._logger.log(LogLevel.Warning, "Error sending keep-alive message" + e);
});
return;
}
}

// The timer needs to be set from a networking callback to avoid Chrome timer throttling from causing timers to run once a minute
Expand Down
Loading