Skip to content

Remove QuarantinedTest attributes from Razor functional test methods #63265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025
Merged

Remove QuarantinedTest attributes from Razor functional test methods #63265

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06c1aea
Initial plan
Copilot Aug 15, 2025
1531782
Remove QuarantinedTest attributes from RazorBuildTest methods
Copilot Aug 15, 2025
0c61179
Remove QuarantinedTest attributes from RazorRuntimeCompilationHosting…
Copilot Aug 15, 2025
01ec93d
Add back using Microsoft.AspNetCore.InternalTesting; statements
Copilot Aug 15, 2025
3180004
Apply suggestion from @radical
radical Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Net.Http;
using System.Reflection;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.AspNetCore.TestHost;
Expand All @@ -19,9 +18,9 @@
// These tests test razor caching which is affected if the site is built by another test class
// Use a named Collection to avoid the test classes running in parallel
[Collection("RazorBuildWebSite")]
public class RazorBuildTest : LoggedTest

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(21,31): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(21,31): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(21,31): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(21,31): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(21,31): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)
{
protected override void Initialize(TestContext context, MethodInfo methodInfo, object[] testMethodArguments, ITestOutputHelper testOutputHelper)

Check failure on line 23 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L23 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(23,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 23 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L23 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(23,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 23 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L23 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(23,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 23 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L23 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(23,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 23 in src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs#L23 

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs(23,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)
{
base.Initialize(context, methodInfo, testMethodArguments, testOutputHelper);
#pragma warning disable ASPDEPR003 // Type or member is obsolete
Expand Down Expand Up @@ -101,7 +100,6 @@
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/56553")]
[LogLevel(LogLevel.Trace)]
public async Task RazorViews_AreUpdatedOnChange()
{
Expand Down Expand Up @@ -140,7 +138,6 @@
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/56553")]
[LogLevel(LogLevel.Trace)]
public async Task RazorPages_AreUpdatedOnChange()
{
Expand Down
4 changes: 1 addition & 3 deletions src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Net.Http;
using System.Reflection;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.InternalTesting;

using Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.AspNetCore.TestHost;
Expand All @@ -16,9 +16,9 @@
// These tests test razor caching which is affected if the site is built by another test class
// Use a named Collection to avoid the test classes running in parallel
[Collection("RazorBuildWebSite")]
public class RazorRuntimeCompilationHostingStartupTest : LoggedTest

Check failure on line 19 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L19 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(19,58): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 19 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L19 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(19,58): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 19 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L19 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(19,58): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 19 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L19 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(19,58): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 19 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L19 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(19,58): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'LoggedTest' could not be found (are you missing a using directive or an assembly reference?)
{
protected override void Initialize(TestContext context, MethodInfo methodInfo, object[] testMethodArguments, ITestOutputHelper testOutputHelper)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(21,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(21,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(21,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: macOS)

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(21,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 21 in src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs#L21 

src/Mvc/test/Mvc.FunctionalTests/RazorRuntimeCompilationHostingStartupTest.cs(21,40): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'TestContext' could not be found (are you missing a using directive or an assembly reference?)
{
base.Initialize(context, methodInfo, testMethodArguments, testOutputHelper);
#pragma warning disable ASPDEPR003 // Type or member is obsolete
Expand Down Expand Up @@ -49,7 +49,6 @@
public HttpClient Client { get; private set; }

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/56553")]
public async Task RazorViews_CanBeServedAndUpdatedViaRuntimeCompilation()
{
// Arrange
Expand Down Expand Up @@ -87,7 +86,6 @@
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/56553")]
public async Task RazorPages_CanBeServedAndUpdatedViaRuntimeCompilation()
{
// Arrange
Expand Down
Loading