Skip to content

Fix race condition in EventTest.PreventDefault_DoNotApplyByDefault #63384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2025
Merged

Fix race condition in EventTest.PreventDefault_DoNotApplyByDefault #63384

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc95671
Fix race condition in EventTest.PreventDefault_DoNotApplyByDefault
oroztocil Aug 22, 2025
d2edb28
Refactor URL change wait into an extension method
oroztocil Aug 22, 2025
d99c428
Remove unneeded extension
oroztocil Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Components/test/E2ETest/Tests/EventTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,12 +278,14 @@ public void PreventDefault_AppliesToFormOnSubmitHandlers()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62533")]
public void PreventDefault_DotNotApplyByDefault()
public void PreventDefault_DoNotApplyByDefault()
{
var appElement = Browser.MountTestComponent<EventPreventDefaultComponent>();
appElement.FindElement(By.Id("form-2-button")).Click();
Assert.Contains("about:blank", Browser.Url);

// The URL should change because the submit event is not prevented
var wait = new WebDriverWait(Browser, TimeSpan.FromSeconds(3));
wait.Until(driver => driver.Url.Contains("about:blank"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the extensions on Browser they centralize things like the wait times and stuff like that, it might be better to use those.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I looked into the existing extensions and did not find one that would cover this kind of wait, so I added one. Is it ok like this?

}

[Fact]
Expand Down
Loading