Skip to content

Fix race condition in EventTest.PreventDefault_DoNotApplyByDefault #63384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2025
Merged

Fix race condition in EventTest.PreventDefault_DoNotApplyByDefault #63384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc95671
Fix race condition in EventTest.PreventDefault_DoNotApplyByDefault
oroztocil Aug 22, 2025
d2edb28
Refactor URL change wait into an extension method
oroztocil Aug 22, 2025
d99c428
Remove unneeded extension
oroztocil Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/WebDriverExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,16 @@ public static void WaitForElementToBeVisible(this IWebDriver browser, By by, int
});
}

public static void WaitForUrlToContain(this IWebDriver browser, string expectedUrlSubstring, int timeoutInSeconds = 5)
{
var wait = new DefaultWait<IWebDriver>(browser)
{
Timeout = TimeSpan.FromSeconds(timeoutInSeconds),
PollingInterval = TimeSpan.FromMilliseconds(100)
};
wait.Until(driver => driver.Url.Contains(expectedUrlSubstring, StringComparison.Ordinal));
}

public static long GetElementPositionWithRetry(this IWebDriver browser, string elementId, int retryCount = 3, int delayBetweenRetriesMs = 100)
{
var jsExecutor = (IJavaScriptExecutor)browser;
Expand Down
3 changes: 1 addition & 2 deletions src/Components/test/E2ETest/Tests/EventTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,7 @@ public void PreventDefault_DoNotApplyByDefault()
appElement.FindElement(By.Id("form-2-button")).Click();

// The URL should change because the submit event is not prevented
var wait = new WebDriverWait(Browser, TimeSpan.FromSeconds(3));
wait.Until(driver => driver.Url.Contains("about:blank"));
Browser.WaitForUrlToContain("about:blank");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so? But you can also search for Browser.Url usages and you might find an existing pattern.

Copy link
Member Author

@oroztocil oroztocil Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there should be implicit waits for this with 'Browser.Contains' or 'Browser.True'. (I see now what extensions you meant.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the unneeded extension method.

}

[Fact]
Expand Down
Loading