Add Changelog for SignalR typescript client #63392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
a team,
halter73 and
wtgodbe
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a changelog system for the SignalR TypeScript client packages. It creates a comprehensive changelog documenting recent releases and implements automated validation to ensure the changelog stays updated when changes are made to the TypeScript client code.
Key Changes
- Adds a new changelog file documenting version history from v8.0.0-preview.1 through v10.0.0-preview.1
- Links to the changelog from both SignalR npm package README files
- Implements CI validation to enforce changelog updates when TypeScript client code changes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/SignalR/clients/ts/CHANGELOG.md | New changelog file documenting release history and changes |
| src/SignalR/clients/ts/signalr/README.md | Added changelog link to main SignalR package README |
| src/SignalR/clients/ts/signalr-protocol-msgpack/README.md | Added changelog link to msgpack protocol package README |
| eng/scripts/CodeCheck.ps1 | Added validation logic to enforce changelog updates for TypeScript changes |
BrennanConroy
commented
Aug 25, 2025
captainsafia
approved these changes
Aug 28, 2025
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Looks good overall! I agree a little bit with Copilot's comment. Even though the URLs aren't case-sensitive maybe we just normalize to lowercase since the CodeCheck scripts assume lowercase as well?
BrennanConroy
commented
Aug 28, 2025
| } | ||
| } | ||
|
|
||
| # Check for relevant changes to SignalR typescript files |
Member
Author
There was a problem hiding this comment.
@wtgodbe Could I get your review/approval of the infra changes?
dotnet-policy-service
bot
added
the
pending-ci-rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a changelog for recent releases
Link to changelog from both npm packages
Add codecheck for CI to fail if a change was made to the npm projects and the changelog wasn't updated
See #50772