Skip to content

Fix unofficial build #63470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 6 commits into from
Aug 28, 2025
Merged

Fix unofficial build #63470

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65345b3
Add missing r
wtgodbe Aug 28, 2025
e515e56
Try something
wtgodbe Aug 28, 2025
0a1dee3
options
wtgodbe Aug 28, 2025
2cba05f
git
wtgodbe Aug 28, 2025
748faa4
Undo
wtgodbe Aug 28, 2025
21e1e58
Fixup
wtgodbe Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 47 additions & 15 deletions .azure/pipelines/ci-unofficial.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ variables:
exclude:artifacts
- template: /eng/common/templates-official/variables/pool-providers.yml@self

esources:
resources:
repositories:
# Repo: 1ESPipelineTemplates/1ESPipelineTemplates
- repository: 1esPipelines
Expand Down Expand Up @@ -111,6 +111,9 @@ extends:
jobName: Code_check
jobDisplayName: Code check
agentOs: Windows
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
steps:
- powershell: ./eng/scripts/CodeCheck.ps1 -ci $(_InternalRuntimeDownloadArgs)
displayName: Run eng/scripts/CodeCheck.ps1
Expand All @@ -127,6 +130,9 @@ extends:
jobName: Windows_build
jobDisplayName: "Build: Windows x64/x86/arm64"
agentOs: Windows
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
steps:
- ${{ if notIn(variables['Build.Reason'], 'PullRequest') }}:
- script: echo "##vso[build.addbuildtag]daily-build"
Expand Down Expand Up @@ -258,6 +264,9 @@ extends:
jobDisplayName: "Build: macOS arm64"
agentOs: macOs
timeoutInMinutes: 90
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch arm64
--pack
Expand Down Expand Up @@ -289,6 +298,9 @@ extends:
jobDisplayName: "Build: macOS x64"
agentOs: macOs
timeoutInMinutes: 90
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--pack
--all
Expand Down Expand Up @@ -319,6 +331,9 @@ extends:
jobDisplayName: "Build: Linux x64"
agentOs: Linux
useHostedUbuntu: false
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch x64
--pack
Expand Down Expand Up @@ -350,6 +365,9 @@ extends:
jobName: Linux_arm_build
jobDisplayName: "Build: Linux ARM"
agentOs: Linux
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch arm
--pack
Expand Down Expand Up @@ -380,6 +398,9 @@ extends:
jobName: Linux_arm64_build
jobDisplayName: "Build: Linux ARM64"
agentOs: Linux
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch arm64
--pack
Expand Down Expand Up @@ -412,6 +433,9 @@ extends:
jobDisplayName: "Build: Linux Musl x64"
agentOs: Linux
container: azureLinux30Net10BuildAmd64
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch x64
--os-name linux-musl
Expand Down Expand Up @@ -446,6 +470,9 @@ extends:
agentOs: Linux
useHostedUbuntu: false
container: azureLinux30Net10BuildAmd64
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch arm
--os-name linux-musl
Expand Down Expand Up @@ -479,6 +506,9 @@ extends:
agentOs: Linux
useHostedUbuntu: false
container: azureLinux30Net10BuildAmd64
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
buildArgs:
--arch arm64
--os-name linux-musl
Expand Down Expand Up @@ -517,6 +547,8 @@ extends:
/p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunBlazorPlaywrightTemplateTests=true /p:DoNotCleanUpTemplates=true
$(_InternalRuntimeDownloadArgs)
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
- powershell: "& ./src/Servers/IIS/tools/UpdateIISExpressCertificate.ps1; & ./src/Servers/IIS/tools/update_schema.ps1"
displayName: Setup IISExpress test certificates and schema
artifacts:
Expand All @@ -540,6 +572,8 @@ extends:
isAzDOTestingJob: true
buildArgs: --all --test --binaryLog /p:RunTemplateTests=false /p:SkipHelixReadyTests=true $(_InternalRuntimeDownloadArgs)
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
- bash: "./eng/scripts/install-nginx-mac.sh"
displayName: Installing Nginx
artifacts:
Expand All @@ -561,6 +595,8 @@ extends:
useHostedUbuntu: false
buildArgs: --all --test --binaryLog /p:RunTemplateTests=false /p:SkipHelixReadyTests=true $(_InternalRuntimeDownloadArgs)
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
- bash: "./eng/scripts/install-nginx-linux.sh"
displayName: Installing Nginx
- bash: "echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p"
Expand All @@ -582,6 +618,9 @@ extends:
jobDisplayName: 'Tests: Helix x64 Subset 1'
agentOs: Windows
timeoutInMinutes: 240
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
steps:
# Build the shared framework
- script: ./eng/build.cmd -ci -prepareMachine -nativeToolsOnMachine -nobl -all -pack -arch x64
Expand Down Expand Up @@ -611,6 +650,9 @@ extends:
jobDisplayName: 'Tests: Helix x64 Subset 2'
agentOs: Windows
timeoutInMinutes: 240
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
steps:
# Build the shared framework
- script: ./eng/build.cmd -ci -prepareMachine -nativeToolsOnMachine -nobl -all -pack -arch x64
Expand Down Expand Up @@ -642,6 +684,9 @@ extends:
agentOs: Windows
isAzDOTestingJob: true
timeoutInMinutes: 240
beforeBuild:
- script: git submodule update --init
displayName: Update submodules
steps:
- script: git submodule update --init
displayName: Update submodules
Comment on lines 691 to 692
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job already has a duplicate submodule update step in the beforeBuild section (lines 688-689). The redundant step in the steps section should be removed to avoid duplication.

Suggested change
- script: git submodule update --init
displayName: Update submodules

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -670,17 +715,4 @@ extends:
path: artifacts/log/
publishOnError: true
includeForks: true
# Source build
- template: /eng/common/templates-official/job/source-build.yml@self
parameters:
enableInternalSources: true
platform:
name: 'Managed'
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream-10-amd64'
buildScript: './eng/build.sh'
buildArguments: '--source-build $(_InternalRuntimeDownloadArgs)'
jobProperties:
timeoutInMinutes: 120
variables:
# Log environment variables in binary logs to ease debugging
MSBUILDLOGALLENVIRONMENTVARIABLES: true

Loading