Skip to content

[Blazor] Skip tests in ThreadingHostedAppTest and ThreadingAppTest #63525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

[Blazor] Skip tests in ThreadingHostedAppTest and ThreadingAppTest #63525

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a1952e
Initial plan
Copilot Sep 3, 2025
3b0bd8d
Skip Threading tests due to unreliability - replace QuarantinedTest w…
Copilot Sep 3, 2025
dd3bf82
Simplify skip messages to use only URL as requested
Copilot Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/Components/test/E2ETest/Tests/ThreadingAppHostedTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,13 @@ protected override void InitializeAsyncCore()
WaitUntilLoaded();
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void HasHeading()
{
Assert.Equal("Hello, world!", Browser.Exists(By.TagName("h1")).Text);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void NavMenuHighlightsCurrentLocation()
{
var activeNavLinksSelector = By.CssSelector(".sidebar a.active");
Expand All @@ -66,8 +64,7 @@ public void NavMenuHighlightsCurrentLocation()
item => Assert.Equal("Home", item.Text.Trim()));
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void CounterPageCanUseThreads()
{
// Navigate to "Counter"
Expand All @@ -84,8 +81,7 @@ public void CounterPageCanUseThreads()
Browser.NotEqual("Current count: 0", () => Browser.Exists(By.CssSelector("h1 + p")).Text);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void HasFetchDataPage()
{
// Navigate to "Fetch data"
Expand Down
18 changes: 6 additions & 12 deletions src/Components/test/E2ETest/Tests/ThreadingAppTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,19 @@ protected override void InitializeAsyncCore()
WaitUntilLoaded();
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void HasTitle()
{
Assert.Equal("Blazor standalone", Browser.Title);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void HasHeading()
{
Assert.Equal("Hello, world!", Browser.Exists(By.TagName("h1")).Text);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54497")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void NavMenuHighlightsCurrentLocation()
{
var activeNavLinksSelector = By.CssSelector(".sidebar a.active");
Expand All @@ -69,8 +66,7 @@ public void NavMenuHighlightsCurrentLocation()
item => Assert.Equal("Home", item.Text.Trim()));
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/58242")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void CounterPageCanUseThreads()
{
// Navigate to "Counter"
Expand All @@ -87,8 +83,7 @@ public void CounterPageCanUseThreads()
Browser.NotEqual("Current count: 0", () => Browser.Exists(By.CssSelector("h1 + p")).Text);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
public void HasFetchDataPage()
{
// Navigate to "Fetch data"
Expand All @@ -109,8 +104,7 @@ public void HasFetchDataPage()
}
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
[Fact(Skip = "Test skipped due to unreliability. See https://github.com/dotnet/aspnetcore/issues/63524")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Just use the URL in all the skipped tests. Do not add any additional text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all skip messages to use only the URL. Commit 3b0bd8d

public void IsStarted()
{
// Read from property
Expand Down
Loading