Fix unofficial build #63530
Merged
Fix unofficial build #63530
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the unofficial build pipeline by suppressing a NuGet package signing validation error. The SiteExtensions build expects real-signed packages, but the unofficial pipeline uses test-signing, causing NU3027 warnings that should be ignored in development builds.
Key changes:
- Add conditional suppression of NU3027 warning for development builds
- Configure unofficial build pipeline to use development build mode
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SiteExtensions/Directory.Build.props | Adds conditional NoWarn property to suppress NU3027 signing validation errors when _DevBuild is true |
| .azure/pipelines/ci-unofficial.yml | Sets _DevBuild=true parameter for the SiteExtension build step in unofficial pipeline |
github-actions
bot
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SiteExtensions build consumes packages that it expects to be real-signed. The unofficial pipeline does test-signing instead, so we should ignore that error there.
Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2785826&view=results