Skip to content

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 4, 2025

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2785973&view=results

Move signing-related NoWarn to a more central spot

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 04:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes unofficial build issues by centralizing the signing-related NoWarn configuration. The change moves a build warning suppression from a subdirectory to the root level to ensure it applies consistently across all build scenarios.

  • Moves NoWarn NU3027 suppression from subdirectory to root Directory.Build.props
  • Centralizes build configuration to fix unofficial build warnings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/SiteExtensions/Directory.Build.props Removes localized NoWarn NU3027 suppression
Directory.Build.props Adds centralized NoWarn NU3027 suppression for dev builds

@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 4, 2025
@wtgodbe wtgodbe merged commit fed42ad into main Sep 4, 2025
6 of 8 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/FixFixUnof branch September 4, 2025 04:08
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant