Skip to content

Fix NavMenuHighlightsCurrentLocation in headless mode #63583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

Fix NavMenuHighlightsCurrentLocation in headless mode #63583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33edda9
Fix NavMenuHighlightsCurrentLocation in headless mode by setting wind…
oroztocil Sep 8, 2025
46df082
Reset browser window size in BrowserTestBase.DisposeAsync
oroztocil Sep 9, 2025
8706896
Catch WebDriverException when resetting window size of closed browser
oroztocil Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Components/test/E2ETest/Tests/ComponentRenderingTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ public void CanUseJsInteropToReferenceElements()
[Fact]
public void CanUseFocusExtensionToFocusElement()
{
Browser.Manage().Window.Size = new System.Drawing.Size(100, 300);
Browser.SetWindowSize(100, 300);
var appElement = Browser.MountTestComponent<ElementFocusComponent>();

// y scroll position before click
Expand Down Expand Up @@ -408,7 +408,7 @@ public void CanUseFocusExtensionToFocusElement()
[Fact]
public void CanUseFocusExtensionToFocusSvgElement()
{
Browser.Manage().Window.Size = new System.Drawing.Size(100, 300);
Browser.SetWindowSize(100, 300);
var appElement = Browser.MountTestComponent<SvgFocusComponent>();

var buttonElement = appElement.FindElement(By.Id("focus-button"));
Expand All @@ -430,7 +430,7 @@ public void CanUseFocusExtensionToFocusSvgElement()
[Fact]
public void CanUseFocusExtensionToFocusElementPreventScroll()
{
Browser.Manage().Window.Size = new System.Drawing.Size(600, 600);
Browser.SetWindowSize(600, 600);
var appElement = Browser.MountTestComponent<ElementFocusComponent>();

var buttonElement = Browser.Exists(By.Id("focus-button-prevented"));
Expand Down
6 changes: 6 additions & 0 deletions src/Components/test/E2ETest/Tests/StandaloneAppTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ public void NavMenuHighlightsCurrentLocation()
var activeNavLinksSelector = By.CssSelector(".sidebar a.active");
var mainHeaderSelector = By.TagName("h1");

// The sidebar is hidden if the screen is too narrow.
// Without setting the window size explicitly, visibility-sensitive properties
// such as IWebElement.Text can return empty strings, causing assertions to fail.
// In particular, this happens in the headless mode (used when running without debugger).
Browser.SetWindowSize(1920, 1080);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this doesn't fail if the physical screen size is lower than this right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on docs and empirical testing:

  • In GUI mode the size is clamped so that the window fits into the screen.
  • In headless mode the window size is set to whatever is specified and the rest of the test executes fine. (I tried 10000x10000 and had no issues.)


// Verify we start at home, with the home link highlighted
Assert.Equal("Hello, world!", Browser.Exists(mainHeaderSelector).Text);
Assert.Collection(Browser.FindElements(activeNavLinksSelector),
Expand Down
7 changes: 7 additions & 0 deletions src/Shared/E2ETesting/WebDriverExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,11 @@ private static bool ShouldIgnore(LogEntry entry)

return false;
}

public static void SetWindowSize(this IWebDriver driver, int width, int height)
{
ArgumentNullException.ThrowIfNull(driver);

driver.Manage().Window.Size = new System.Drawing.Size(width, height);
}
}
Loading