Don't build the composite runtime pack on Windows when we don't ship it #63724
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R2R composite binaries don't work with binskim. We don't need this on Windows anyway, so don't build it in the first place.
There was a problem hiding this comment.
Pull Request Overview
This PR stops building the composite ReadyToRun runtime pack on Windows, as it is not shipped there and causes BinSkim failures. It moves the composite project out of the general project list and conditions its inclusion on non-Windows targets.
- Remove unconditional inclusion of aspnetcore-runtime-composite.proj from the main DotNetProjects item group
- Add a separate, OS-gated inclusion for the composite runtime pack
- Add an explanatory comment clarifying the rationale
github-actions
bot
added
the
area-infrastructure
dotnet-policy-service
bot
added
the
pending-ci-rerun
wtgodbe
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R2R composite binaries don't work with binskim. We don't need this on Windows anyway, so don't build it in the first place.
Fixes binskim failures in the unified build.