Skip to content

Fix hot reload routing issue by validating route templates in EndpointHtmlRenderer #63737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix hot reload routing issue by validating route templates in EndpointHtmlRenderer #63737

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1586c87
Initial plan
Copilot Sep 19, 2025
8271b88
Fix hot reload routing issue with stale template handling
Copilot Sep 19, 2025
bb16b3b
Add comprehensive tests for hot reload routing fix
Copilot Sep 19, 2025
cdce445
Fix hot reload routing by invalidating cached route data
Copilot Sep 19, 2025
caad798
Clean up test file and finalize hot reload routing fix
Copilot Sep 19, 2025
a4d6cf9
Rework hot reload fix - validate route template against component att…
Copilot Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/Components/Endpoints/src/DependencyInjection/EndpointRoutingStateProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,34 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.AspNetCore.Components.HotReload;
using Microsoft.AspNetCore.Components.Routing;

namespace Microsoft.AspNetCore.Components.Endpoints.DependencyInjection;

internal sealed class EndpointRoutingStateProvider : IRoutingStateProvider
{
public RouteData? RouteData { get; internal set; }
private static volatile bool _cacheInvalidated;
private RouteData? _routeData;
Copy link
Member

@oroztocil oroztocil Sep 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot _routeData is a non-static field yet you treat it as a static cache. This does not seem correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Rework the solution. Investigate how the EndpointRoutingStateProvider is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right about the flawed design. I've reworked the solution to fix the root cause in EndpointHtmlRenderer instead of using a broken static flag approach.

The new solution validates that the endpoint's route template matches the component's current route attributes before setting the template. When they don't match (hot reload scenario), the template stays null, forcing the router to use normal routing with updated metadata. Commit: caad798


static EndpointRoutingStateProvider()
{
if (HotReloadManager.Default.MetadataUpdateSupported)
{
HotReloadManager.Default.OnDeltaApplied += InvalidateCache;
}
}

public RouteData? RouteData
{
get => _cacheInvalidated ? null : _routeData;
internal set => _routeData = value;
}

private static void InvalidateCache()
{
// Invalidate cached route data during hot reload to prevent stale route data
// from being used when component route templates change
_cacheInvalidated = true;
}
}
Loading