Skip to content

chore: remove obsolete comment from OpenApiDocumentProvider #63776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

chore: remove obsolete comment from OpenApiDocumentProvider #63776

merged 1 commit into from
Sep 23, 2025

Conversation

xC0dex
Copy link
Contributor

@xC0dex xC0dex commented Sep 23, 2025

Remove obsolete comment from OpenApiDocumentProvider

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

This PR removes an obsolete comment from the source code since we have been using async APIs since version 2.0.0 of the Microsoft.OpenAPI package.

@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Sep 23, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 23, 2025
@xC0dex xC0dex marked this pull request as ready for review September 23, 2025 11:07
@xC0dex xC0dex requested review from a team and captainsafia as code owners September 23, 2025 11:07
@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 11:07
Copilot
Copilot AI reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an obsolete comment about the lack of async APIs in the Microsoft.OpenAPI package. The comment referenced an issue that has been resolved since version 2.0.0 of the package now supports async operations.

  • Removes outdated documentation that no longer applies to the current version of Microsoft.OpenAPI

@martincostello martincostello added feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Sep 23, 2025
This was referenced Sep 23, 2025
Open
Closed
@captainsafia captainsafia merged commit f2793d1 into dotnet:main Sep 23, 2025
29 of 31 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@captainsafia captainsafia captainsafia approved these changes

+1 more reviewer

@martincostello martincostello martincostello approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc community-contribution Indicates that the PR has been added by a community member feature-openapi

Projects

None yet

Milestone

11.0-preview1

Development

Successfully merging this pull request may close these issues.

3 participants

@xC0dex @martincostello @captainsafia