Prevent JS sources minification in debug #63902
Closed
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
npm run build
should not minify js files that it's producing insrc\Components\Web.JS\dist\Debug
. That's why we're using debug mode. There's a lot of hassle with debugging the minified files now or having to look for the place in rollup to disable minification.Description
dist\Debug
dist\Release
Before this change:
both
dist\Debug
anddist\Release
had same, minified contents.Use case:
Replacing packages in user's repro app with the current packs from the repo.
This is just a proposal and should be discussed if there is some real reason why we chose to minify in debug.