[release/9.0] Fix nginx install on mac, linux #63966
Merged
+5
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes nginx installation across macOS and Linux platforms by consolidating platform-specific scripts into a single unified script and updating to a newer nginx version.
- Consolidates platform-specific nginx installation scripts into one unified script
- Updates nginx version from 1.26.3 to 1.29.1
- Updates CI pipeline references to use the consolidated script
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/scripts/install-nginx.sh | Updates nginx version to 1.29.1 in the unified installation script |
| eng/scripts/install-nginx-mac.sh | Removes macOS-specific installation script in favor of unified approach |
| .azure/pipelines/ci.yml | Updates pipeline to use unified nginx installation script for both macOS and Linux |
| .azure/pipelines/ci-public.yml | Updates public pipeline to use unified nginx installation script for both macOS and Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already fixed in main, 10, & 8. Centralize on 1 script for installing nginx on non-win, and pin to the latest working version.