Blazor 404 code re-execution is compatible with OnNavigateAsync
#64034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Blazor 404 re-execution was not working properly when the Router component had an OnNavigateAsync handler. The fix allows rendering to proceed during 404 re-execution scenarios while still preventing it during client-side navigation when lazy loading is in progress.
Key changes:
- Modified the Router component to differentiate between server-side rendering (SSR) scenarios and client-side navigation
- Updated the navigation blocking logic to check if route data is available from SSR before blocking rendering
- Added comprehensive test coverage for the 404 re-execution scenario with
OnNavigateAsync
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Components/Components/src/Routing/Router.cs | Updated navigation logic to allow rendering during SSR/re-execution while maintaining blocking for client navigation |
| src/Components/test/testassets/Components.TestServer/RazorComponents/App.razor | Added test infrastructure with configurable OnNavigateAsync handler and query parameter support |
| src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs | Added end-to-end test to verify 404 re-execution works with OnNavigateAsync |
src/Components/test/testassets/Components.TestServer/RazorComponents/App.razor
Outdated
Show resolved
Hide resolved
src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs
Outdated
Show resolved
Hide resolved
…onents/App.razor Co-authored-by: Copilot <[email protected]>
…tyTest.cs Co-authored-by: Copilot <[email protected]>
|
Failures of |
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not prevent rendering for router that has
OnNavigateAsyncwhen navigation already started.In #24225 we blocked rendering for router that has
OnNavigateAsyncthat is typically used for lazy loading actions. The reason was that rendering was interfering with lazy loading logic in state: #24211.With rendering blocked, 404 re-execution mechanism is not able to render the contents of 404 page. We can differentiate between a situation when SSR match or re-execution happened from a situation when we're performing purely client navigation. In the former case,
RoutingStateProvider?.RouteDatais populated byEndpointHtmlProviderduring SSR.Description
OnNavigateAsyncifRefreshis not triggered by the client.Fixes #63933