[DO NOT MERGE] Install scripts update validation PR #64064
Conversation
NikolaMilosavljevic
added
the
* NO MERGE *
github-actions
bot
added
the
area-infrastructure
There was a problem hiding this comment.
Pull Request Overview
This PR updates the .NET install script URLs in both PowerShell and shell scripts to point to the new GitHub repository location instead of the builds.dotnet.microsoft.com domain.
Key Changes
- Updated install script URL source from builds.dotnet.microsoft.com to raw.githubusercontent.com
- Changes affect both Windows (PowerShell) and Unix (shell) script versions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/tools.sh | Updated .NET install script URL to use GitHub raw content endpoint |
| eng/common/tools.ps1 | Updated .NET install script URL to use GitHub raw content endpoint |
| local root=$1 | ||
| local install_script="$root/dotnet-install.sh" | ||
| local install_script_url="https://builds.dotnet.microsoft.com/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.sh" | ||
| local install_script_url="https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.sh" |
There was a problem hiding this comment.
The hardcoded 'main' branch reference in the URL could lead to unexpected behavior if the main branch is updated. Consider using a specific commit SHA or version tag to ensure reproducible builds, or document why using the main branch is acceptable for this use case.
| local install_script_url="https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.sh" | |
| # Use a specific version tag for reproducibility. Update as needed. | |
| local install_script_url="https://raw.githubusercontent.com/dotnet/install-scripts/v1.5.0/src/dotnet-install.sh" |
Copilot uses AI. Check for mistakes.
| Create-Directory $dotnetRoot | ||
| $ProgressPreference = 'SilentlyContinue' # Don't display the console progress UI - it's a huge perf hit | ||
| $uri = "https://builds.dotnet.microsoft.com/dotnet/scripts/$dotnetInstallScriptVersion/dotnet-install.ps1" | ||
| $uri = "https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.ps1" |
There was a problem hiding this comment.
The hardcoded 'main' branch reference in the URL could lead to unexpected behavior if the main branch is updated. Consider using a specific commit SHA or version tag to ensure reproducible builds, or document why using the main branch is acceptable for this use case.
| $uri = "https://raw.githubusercontent.com/dotnet/install-scripts/main/src/dotnet-install.ps1" | |
| $uri = "https://raw.githubusercontent.com/dotnet/install-scripts/v1.5.0/src/dotnet-install.ps1" |
Copilot uses AI. Check for mistakes.
|
The failure is unrelated to verification of install scripts. |
1 participant
No description provided.