Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 15, 2025

Summary

Fixes the issue where productVersion.txt and aspnetcore-productVersion.txt were incorrectly marked as non-shipping artifacts in the ASP.NET Core 8.0 build configuration. These files are required in the final CDN locations and must be marked as shipping artifacts.

Changes

Modified eng/Publishing.props to change the ManifestArtifactData property from NonShipping=true to NonShipping=false for both:

  • productVersion.txt
  • aspnetcore-productVersion.txt

This ensures these version files are properly included in the shipping manifest and published to the correct CDN locations alongside other shipping artifacts.

Impact

Without this change, the productVersion.txt files would not be available in the expected CDN locations, which could impact downstream consumers that rely on these files to determine the ASP.NET Core runtime version.

Fixes #[issue_number]

Original prompt

This section details on the original issue you should resolve

<issue_title>productVersion.txt is non-shipping in 8.0 aspnetcore</issue_title>
<issue_description>productVersion.txt should be marked as shipping. It's needed in the final CDN locations.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #64066


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@Copilot Copilot AI changed the title [WIP] Fix productVersion.txt to be marked as shipping Mark productVersion.txt as shipping artifact in 8.0 Oct 15, 2025
@Copilot Copilot AI requested a review from mmitche October 15, 2025 22:17
Copilot finished work on behalf of mmitche October 15, 2025 22:17
@mmitche mmitche marked this pull request as ready for review October 15, 2025 22:49
@mmitche mmitche requested a review from a team as a code owner October 15, 2025 22:49
@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 22:49
@mmitche mmitche enabled auto-merge (squash) October 15, 2025 22:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the shipping artifact classification for version files in the ASP.NET Core 8.0 build configuration. The productVersion.txt and aspnetcore-productVersion.txt files were incorrectly marked as non-shipping artifacts, which would prevent them from being published to their expected CDN locations.

Key Changes:

  • Updated ManifestArtifactData property from NonShipping=true to NonShipping=false for both version files

@mmitche mmitche merged commit 46a1d0f into release/8.0 Oct 15, 2025
24 of 25 checks passed
@mmitche mmitche deleted the copilot/fix-productversion-txt-shipping branch October 15, 2025 23:58
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.22 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants