Revert log level severity for unknown proxy in ForwardedHeadersMiddleware #64090
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert logging severity in ForwardedHeaders middleware
Description
As part of strengthening our security posture in the ForwardedHeaders middleware we increased the severity of a log from
Debug
toWarning
hoping to give consumers a more obvious signal that unexpected requests were hitting their application.Unfortunately, that change doesn't have the intended effect as it's not uncommon to receive valid requests that have unknown IP addresses in the forwarded headers. e.g. In a proxy scenario where the proxy isn't hosted in a well-defined IP range, or a request goes through many proxy layers and the application is only aware of the last layer, etc.
Customer Impact
Customers are receiving lots of Warning logs, which may trigger telemetry checks, unexpectedly increase log storage size, etc.
Regression?
Change was intended as a signal that unexpected requests were being received, which isn't really accurate in real apps.
Risk
Just changing a log level to what it was before.
Verification
Packaging changes reviewed?