Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 24, 2025

Part of dotnet/dotnet#711, fixes #64510. We don't ship via the official build anymore. Making our build assetless allows aspnetcore commits to flow to the VMR much quicker after merging.

@wtgodbe wtgodbe requested a review from ViktorHofer November 24, 2025 17:58
@wtgodbe wtgodbe requested a review from a team as a code owner November 24, 2025 17:58
Copilot AI review requested due to automatic review settings November 24, 2025 17:58
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 24, 2025
@wtgodbe wtgodbe changed the title Switch to assetless build Switch to assetless build for official builds Nov 24, 2025
Copilot finished reviewing on behalf of wtgodbe November 24, 2025 18:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transitions the ASP.NET Core repository to an assetless build configuration to accelerate commit flow to the Virtual Monolithic Repository (VMR). Since ASP.NET Core no longer ships via the official build, this change eliminates unnecessary asset publishing operations and removes build dependencies that previously blocked the publish-build-assets job from executing.

Key Changes

  • Simplified publish-build-assets job by removing all dependsOn conditions, allowing it to run immediately
  • Added isAssetlessBuild: true parameter to indicate no shipping assets are produced
  • Removed dependencies on Windows, macOS, Linux builds, code signing, tests, and source indexing jobs
Comments suppressed due to low confidence (1)

.azure/pipelines/ci.yml:731

  • The post-build template is missing the isAssetlessBuild: true parameter. For consistency with the assetless build approach, this parameter should be added to the post-build template parameters to ensure it also skips asset publishing operations (via the -SkipAssetsPublishing flag). Add isAssetlessBuild: true after line 731.
      - template: /eng/common/templates-official/post-build/post-build.yml@self
        parameters:
          publishingInfraVersion: 3
          enableSymbolValidation: false
          enableSigningValidation: false
          enableNugetValidation: false
          publishInstallersAndChecksums: true
          publishAssetsImmediately: true

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this works. Double check post-merge.

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 24, 2025

Not sure this works. Double check post-merge.

Will do - I just copied what SDK did: https://github.com/dotnet/sdk/pull/49113/files

@wtgodbe wtgodbe merged commit edda51e into main Nov 24, 2025
37 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/assetless branch November 24, 2025 19:04
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Nov 24, 2025
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 24, 2025

/backport to release/10.0

@github-actions
Copy link
Contributor

Started backporting to release/10.0 (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make aspnetcore main build assetless

3 participants