Skip to content

Fix JwtBearerOptions.Authority incorrectly set from empty configuration values #64936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+71 −2
Draft

Fix JwtBearerOptions.Authority incorrectly set from empty configuration values #64936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b57ed59
Initial plan
Copilot Jan 5, 2026
a6871ca
Fix JwtBearerOptions.Authority not respecting null/empty configuratio…
Copilot Jan 5, 2026
f9ee5fb
Address code review feedback: improve test assertions clarity
Copilot Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Security/Authentication/JwtBearer/src/JwtBearerConfigureOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ public void Configure(string? name, JwtBearerOptions options)
var audience = configSection[nameof(TokenValidationParameters.ValidAudience)];
var audiences = configSection.GetSection(nameof(TokenValidationParameters.ValidAudiences)).GetChildren().Select(aud => aud.Value).ToList();

options.Authority = configSection[nameof(options.Authority)] ?? options.Authority;
if (!string.IsNullOrWhiteSpace(configSection[nameof(options.Authority)]))
{
options.Authority = configSection[nameof(options.Authority)];
}
options.BackchannelTimeout = StringHelpers.ParseValueOrDefault(configSection[nameof(options.BackchannelTimeout)], _invariantTimeSpanParse, options.BackchannelTimeout);
options.Challenge = configSection[nameof(options.Challenge)] ?? options.Challenge;
options.ForwardAuthenticate = configSection[nameof(options.ForwardAuthenticate)] ?? options.ForwardAuthenticate;
Expand All @@ -58,7 +61,10 @@ public void Configure(string? name, JwtBearerOptions options)
options.ForwardSignOut = configSection[nameof(options.ForwardSignOut)] ?? options.ForwardSignOut;
options.IncludeErrorDetails = StringHelpers.ParseValueOrDefault(configSection[nameof(options.IncludeErrorDetails)], bool.Parse, options.IncludeErrorDetails);
options.MapInboundClaims = StringHelpers.ParseValueOrDefault( configSection[nameof(options.MapInboundClaims)], bool.Parse, options.MapInboundClaims);
options.MetadataAddress = configSection[nameof(options.MetadataAddress)] ?? options.MetadataAddress;
if (!string.IsNullOrWhiteSpace(configSection[nameof(options.MetadataAddress)]))
{
options.MetadataAddress = configSection[nameof(options.MetadataAddress)]!;
}
options.RefreshInterval = StringHelpers.ParseValueOrDefault(configSection[nameof(options.RefreshInterval)], _invariantTimeSpanParse, options.RefreshInterval);
options.RefreshOnIssuerKeyNotFound = StringHelpers.ParseValueOrDefault(configSection[nameof(options.RefreshOnIssuerKeyNotFound)], bool.Parse, options.RefreshOnIssuerKeyNotFound);
options.RequireHttpsMetadata = StringHelpers.ParseValueOrDefault(configSection[nameof(options.RequireHttpsMetadata)], bool.Parse, options.RequireHttpsMetadata);
Expand Down
63 changes: 63 additions & 0 deletions src/Security/Authentication/test/JwtBearerTests_Handler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,4 +1357,67 @@ private static (string tokenText, SymmetricSecurityKey key) CreateStandardTokenA
var tokenText = new JwtSecurityTokenHandler().WriteToken(token);
return (tokenText, key);
}

[Fact]
public void AuthorityNotSetFromEmptyConfiguration()
{
// Arrange
var services = new ServiceCollection();
var config = new ConfigurationBuilder().AddInMemoryCollection([
new("Authentication:Schemes:Bearer:Authority", ""),
new("Authentication:Schemes:Bearer:MetadataAddress", ""),
]).Build();
services.AddSingleton<IConfiguration>(config);

// Act
RegisterAuth(services.AddAuthentication());
var sp = services.BuildServiceProvider();

// Assert
var jwtBearerOptions = sp.GetRequiredService<IOptionsMonitor<JwtBearerOptions>>().Get(JwtBearerDefaults.AuthenticationScheme);
Assert.Null(jwtBearerOptions.Authority);
Assert.Null(jwtBearerOptions.MetadataAddress);
}

[Fact]
public void AuthorityNotSetFromWhitespaceConfiguration()
{
// Arrange
var services = new ServiceCollection();
var config = new ConfigurationBuilder().AddInMemoryCollection([
new("Authentication:Schemes:Bearer:Authority", " "),
new("Authentication:Schemes:Bearer:MetadataAddress", " "),
]).Build();
services.AddSingleton<IConfiguration>(config);

// Act
RegisterAuth(services.AddAuthentication());
var sp = services.BuildServiceProvider();

// Assert
var jwtBearerOptions = sp.GetRequiredService<IOptionsMonitor<JwtBearerOptions>>().Get(JwtBearerDefaults.AuthenticationScheme);
Assert.Null(jwtBearerOptions.Authority);
Assert.Null(jwtBearerOptions.MetadataAddress);
}

[Fact]
public void AuthoritySetFromValidConfiguration()
{
// Arrange
var services = new ServiceCollection();
var config = new ConfigurationBuilder().AddInMemoryCollection([
new("Authentication:Schemes:Bearer:Authority", "https://example.com"),
new("Authentication:Schemes:Bearer:MetadataAddress", "https://example.com/.well-known/openid-configuration"),
]).Build();
services.AddSingleton<IConfiguration>(config);

// Act
RegisterAuth(services.AddAuthentication());
var sp = services.BuildServiceProvider();

// Assert
var jwtBearerOptions = sp.GetRequiredService<IOptionsMonitor<JwtBearerOptions>>().Get(JwtBearerDefaults.AuthenticationScheme);
Assert.Equal("https://example.com", jwtBearerOptions.Authority);
Assert.Equal("https://example.com/.well-known/openid-configuration", jwtBearerOptions.MetadataAddress);
}
}
Loading