-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add support for automatically adding the dev cert to the Windows certificate store when trusted in WSL #64966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+98
−0
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d653ab0
Add ability to trust certificate in windows store from WSL
danegsta 6efd7e6
Add certificate with friendly name and additional WSL checks
danegsta 89676e0
Initial plan
Copilot e31abab
Fix command injection vulnerability using -EncodedCommand with Base64
Copilot 497b40f
Remove redundant string escaping since Base64 encoding handles all sp…
Copilot bcbf3ac
Re-add PowerShell single-quote escaping to prevent injection within P…
Copilot 1b95e15
Merge pull request #64969 from dotnet/copilot/sub-pr-64966
danegsta ac96f88
Read the certificate from bytes instead of from a file path
danegsta 1579e80
Add a comment pointing out that the cert trust is a no-op if the cert…
danegsta 801561a
Merge remote-tracking branch 'upstream/main' into danegsta/wslCertTrust
danegsta 88afbde
Merge remote-tracking branch 'upstream/main' into danegsta/wslCertTrust
danegsta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care if the other linux checks run? Should this check if
sawTrustFailureis alreadytrue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to skip just because we saw a failure as it still makes sense to run in a partial success state. There's already a check on line 338 that will exit early if there wasn't any success trusting the certificate, so if we made it to this point the certificate was at least trusted in some capacity. We still want all the other Linux specific logic to run on WSL since the goal is to trust it in both WSL and Windows in that case.