Skip to content

Fix command injection vulnerability in WSL certificate trust #64969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danegsta merged 4 commits into from
Jan 7, 2026
Merged

Fix command injection vulnerability in WSL certificate trust #64969

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89676e0
Initial plan
Copilot Jan 7, 2026
e31abab
Fix command injection vulnerability using -EncodedCommand with Base64
Copilot Jan 7, 2026
497b40f
Remove redundant string escaping since Base64 encoding handles all sp…
Copilot Jan 7, 2026
bcbf3ac
Re-add PowerShell single-quote escaping to prevent injection within P…
Copilot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Shared/CertificateGeneration/UnixCertificateManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,9 @@ private static bool TryTrustCertificateInWindowsStore(string certificatePath)
// PowerShell command to import the certificate into the CurrentUser Root store.
// We use Import-Certificate which can handle PEM files on modern Windows.
// The -CertStoreLocation parameter specifies the store location.
// Using -EncodedCommand with Base64 encoding to avoid command shell escaping issues.
// We still need to escape single quotes within the PowerShell script itself to prevent
// PowerShell injection vulnerabilities.
var escapedPath = certificatePath.Replace("'", "''");
var escapedFriendlyName = WslFriendlyName.Replace("'", "''");
var powershellScript = $@"
Expand All @@ -628,7 +631,10 @@ private static bool TryTrustCertificateInWindowsStore(string certificatePath)
$store.Close()
";

var startInfo = new ProcessStartInfo(PowerShellCommand, $"-NoProfile -NonInteractive -Command \"{powershellScript}\"")
// Encode the PowerShell script to Base64 (UTF-16LE as required by PowerShell)
var encodedCommand = Convert.ToBase64String(System.Text.Encoding.Unicode.GetBytes(powershellScript));

var startInfo = new ProcessStartInfo(PowerShellCommand, $"-NoProfile -NonInteractive -EncodedCommand {encodedCommand}")
{
RedirectStandardOutput = true,
RedirectStandardError = true,
Expand Down
Loading