Made SymbolResult internal

Author: KathleenDollard

src/System.CommandLine.Subsystems/Directives/DiagramSubsystem.cs

@@ -57,6 +57,7 @@ internal static StringBuilder Diagram(ParseResult parseResult)
         return builder;
     }
 
+    /*
     private static void Diagram(
         StringBuilder builder,
         SymbolResult symbolResult,
@@ -66,7 +67,7 @@ private static void Diagram(
         {
             builder.Append('!');
         }
-
+    */
 // TODO: Directives
 /*
         switch (symbolResult)
@@ -176,6 +177,6 @@ private static void Diagram(
                 }
             }
         }
-*/
     }
+*/
 }

src/System.CommandLine/Parsing/ParseError.cs

@@ -10,7 +10,7 @@ public sealed class ParseError
     {
         // TODO: add position
         // TODO: reevaluate whether we should be exposing a SymbolResult here
-        public ParseError(
+        internal ParseError(
             string message, 
             SymbolResult? symbolResult = null)
         {
@@ -20,18 +20,33 @@ public ParseError(
             }
 
             Message = message;
+            /*
             SymbolResult = symbolResult;
+            */
+        }
+
+        public ParseError(
+            string message)
+        {
+            if (string.IsNullOrWhiteSpace(message))
+            {
+                throw new ArgumentException("Value cannot be null or whitespace.", nameof(message));
+            }
+
+            Message = message;
         }
 
         /// <summary>
         /// A message to explain the error to a user.
         /// </summary>
         public string Message { get; }
 
+        /* Consider how results are attached to errors now that we have ValueResult and CommandValueResult. Should there be a common base?
         /// <summary>
         /// The symbol result detailing the symbol that failed to parse and the tokens involved.
         /// </summary>
         public SymbolResult? SymbolResult { get; }
+        */
 
         /// <inheritdoc />
         public override string ToString() => Message;

src/System.CommandLine/Parsing/SymbolResult.cs

@@ -8,7 +8,7 @@ namespace System.CommandLine.Parsing
     /// <summary>
     /// A result produced during parsing for a specific symbol.
     /// </summary>
-    public abstract class SymbolResult
+    internal abstract class SymbolResult
     {
 // TODO: make this a property and protected if possible
         internal readonly SymbolResultTree SymbolResultTree;
@@ -72,12 +72,14 @@ public IEnumerable<ParseError> Errors
         /// <returns>An argument result if the argument was matched by the parser or has a default value; otherwise, <c>null</c>.</returns>
         internal ArgumentResult? GetResult(CliArgument argument) => SymbolResultTree.GetResult(argument);
 
+        /* Not used
         /// <summary>
         /// Finds a result for the specific command anywhere in the parse tree, including parent and child symbol results.
         /// </summary>
         /// <param name="command">The command for which to find a result.</param>
         /// <returns>An command result if the command was matched by the parser; otherwise, <c>null</c>.</returns>
         internal CommandResult? GetResult(CliCommand command) => SymbolResultTree.GetResult(command);
+        */
 
         /// <summary>
         /// Finds a result for the specific option anywhere in the parse tree, including parent and child symbol results.
@@ -103,6 +105,7 @@ public IEnumerable<ParseError> Errors
         public SymbolResult? GetResult(string name) => 
             SymbolResultTree.GetResult(name);
 
+        /* Not used
         /// <inheritdoc cref="ParseResult.GetValue{T}(CliArgument{T})"/>
         public T? GetValue<T>(CliArgument<T> argument)
         {
@@ -126,6 +129,7 @@ public IEnumerable<ParseError> Errors
 
             return CliArgument<T>.CreateDefaultValue();
         }
+        */
 
         /// <summary>
         /// Gets the value for a symbol having the specified name anywhere in the parse tree.