Fix #2574 #2657
Open
Fix #2574 #2657
+44
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
reviewed
Aug 11, 2025
There was a problem hiding this comment.
I've provided my reasoning behind the change. I would be happy to hear the opinions of @baronfel and @jeffhandley. I know Uri is a frequently used type and this could have been a bad decision.
| @@ -286,5 +286,17 @@ private static Dictionary<Type, TryConvertString> StringConverters | |||
| value = default; | |||
| return false; | |||
| }, | |||
|
|
|||
| [typeof(Uri)] = (string input, out object? value) => | |||
There was a problem hiding this comment.
I've removed this on purpose in #2127 in order to reduce the number of dependencies and reduce the size of a published NativeAOT app. IIRC it allows us to not include System.Private.Uri.dll for every published app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2574.