Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit b35fe3e

Browse files
committed
Remove SignAssembly=false from test assemblies
Setting SignAssembly to false breaks loading our test assemblies in XUnit using the current folder structure we use. It doesn't show up in the open, because we always sign the assemblies, ignoring this setting. But in our official drops, we respect the property, and then are unable to run these 12 tests.
1 parent 11d32b3 commit b35fe3e

File tree

12 files changed

+0
-12
lines changed

12 files changed

+0
-12
lines changed

src/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<OutputType>Library</OutputType>
99
<AppDesignerFolder>Properties</AppDesignerFolder>
1010
<AssemblyName>System.Diagnostics.FileVersionInfo.Tests</AssemblyName>
11-
<SignAssembly>false</SignAssembly>
1211
<ProjectGuid>{6DFDB760-CC88-48AE-BD81-C64844EA3CBC}</ProjectGuid>
1312
<NuGetPackageImportStamp>2fda0f27</NuGetPackageImportStamp>
1413
</PropertyGroup>

src/System.IO.MemoryMappedFiles/tests/MemoryMappedFile/System.IO.MemoryMappedFiles.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
<WarningLevel>4</WarningLevel>
2727
</PropertyGroup>
2828
<PropertyGroup>
29-
<SignAssembly>false</SignAssembly>
3029
</PropertyGroup>
3130
<PropertyGroup>
3231
<RootNamespace>f</RootNamespace>

src/System.IO.MemoryMappedFiles/tests/MemoryMappedViewAccessor/System.IO.MemoryMappedViewAccessor.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<WarningLevel>4</WarningLevel>
2929
</PropertyGroup>
3030
<PropertyGroup>
31-
<SignAssembly>false</SignAssembly>
3231
</PropertyGroup>
3332
<ItemGroup>
3433
<Compile Include="Dispose.cs" />

src/System.IO.MemoryMappedFiles/tests/MemoryMappedViewStream/System.IO.MemoryMappedViewStream.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
<WarningLevel>4</WarningLevel>
2828
</PropertyGroup>
2929
<PropertyGroup>
30-
<SignAssembly>false</SignAssembly>
3130
</PropertyGroup>
3231
<ItemGroup>
3332
<Compile Include="Dispose.cs" />

src/System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<OutputType>Library</OutputType>
99
<AppDesignerFolder>Properties</AppDesignerFolder>
1010
<AssemblyName>System.IO.Pipes.Tests</AssemblyName>
11-
<SignAssembly>false</SignAssembly>
1211
<ProjectGuid>{142469EC-D665-4FE2-845A-FDA69F9CC557}</ProjectGuid>
1312
<NuGetPackageImportStamp>d2615b94</NuGetPackageImportStamp>
1413
</PropertyGroup>

src/System.IO.UnmanagedMemoryStream/tests/System.IO.UnmanagedMemoryStream.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
2020
</PropertyGroup>
2121
<PropertyGroup>
22-
<SignAssembly>false</SignAssembly>
2322
</PropertyGroup>
2423
<ItemGroup>
2524
<Compile Include="ArrayHelpers.cs" />

src/System.Linq.Parallel/tests/System.Linq.Parallel.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<AppDesignerFolder>Properties</AppDesignerFolder>
1111
<RootNamespace>System.Linq.Parallel.Tests</RootNamespace>
1212
<AssemblyName>System.Linq.Parallel.Tests</AssemblyName>
13-
<SignAssembly>false</SignAssembly>
1413
<NuGetPackageImportStamp>8be98411</NuGetPackageImportStamp>
1514
</PropertyGroup>
1615
<!-- Default configurations to help VS understand the configurations -->

src/System.Runtime.Serialization.Json/tests/System.Runtime.Serialization.Json.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<AppDesignerFolder>Properties</AppDesignerFolder>
1010
<RootNamespace>System.Runtime.Serialization.Json.Tests</RootNamespace>
1111
<AssemblyName>System.Runtime.Serialization.Json.Tests</AssemblyName>
12-
<SignAssembly>false</SignAssembly>
1312
<ProjectGuid>{701CB3BC-00DC-435D-BDE4-C5FC29A708A7}</ProjectGuid>
1413
</PropertyGroup>
1514
<ItemGroup>

src/System.Runtime.Serialization.Xml/tests/System.Runtime.Serialization.Xml.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<AppDesignerFolder>Properties</AppDesignerFolder>
1010
<RootNamespace>System.Runtime.Serialization.Xml.Tests</RootNamespace>
1111
<AssemblyName>System.Runtime.Serialization.Xml.Tests</AssemblyName>
12-
<SignAssembly>false</SignAssembly>
1312
<ProjectGuid>{30CAB353-089E-4294-B23B-F2DD1D945654}</ProjectGuid>
1413
</PropertyGroup>
1514
<ItemGroup>

src/System.Text.RegularExpressions/tests/System.Text.RegularExpressions.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<OutputType>Library</OutputType>
1010
<AppDesignerFolder>Properties</AppDesignerFolder>
1111
<AssemblyName>System.Text.RegularExpressions.Tests</AssemblyName>
12-
<SignAssembly>false</SignAssembly>
1312
</PropertyGroup>
1413
<!-- Default configurations to help VS understand the configurations -->
1514
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">

0 commit comments

Comments
 (0)