refactor Announcement to use with DI

Author: bartizan

DevProxy/Announcement.cs

@@ -6,11 +6,12 @@
 
 namespace DevProxy;
 
-static class Announcement
+internal class Announcement(HttpClient httpClient)
 {
     private static readonly Uri announcementUrl = new("https://aka.ms/devproxy/announcement");
+    private readonly HttpClient _httpClient = httpClient;
 
-    public static async Task ShowAsync()
+    public async Task ShowAsync()
     {
         var announcement = await GetAsync();
         if (!string.IsNullOrEmpty(announcement))
@@ -22,12 +23,11 @@ public static async Task ShowAsync()
         }
     }
 
-    public static async Task<string?> GetAsync()
+    private async Task<string?> GetAsync()
     {
         try
         {
-            using var client = new HttpClient();
-            return await client.GetStringAsync(announcementUrl);
+            return await _httpClient.GetStringAsync(announcementUrl);
         }
         catch
         {

DevProxy/Extensions/IServiceCollectionExtensions.cs

@@ -45,6 +45,7 @@ static IServiceCollection AddApplicationServices(
             .AddSingleton<UpdateNotification>()
             .AddSingleton<ProxyEngine>()
             .AddSingleton<DevProxyCommand>()
+            .AddSingleton<Announcement>()
             .AddHttpClient();
 
         _ = services.AddPlugins(configuration, options);

DevProxy/Program.cs

@@ -32,12 +32,14 @@ static WebApplication BuildApplication(string[] args, DevProxyConfigOptions opti
 
     return app;
 }
-_ = Announcement.ShowAsync();
 
 var options = new DevProxyConfigOptions();
 options.ParseOptions(args);
 var app = BuildApplication(args, options);
 
+var announcement = app.Services.GetRequiredService<Announcement>();
+_ = announcement.ShowAsync();
+
 var devProxyCommand = app.Services.GetRequiredService<DevProxyCommand>();
 var loggerFactory = app.Services.GetRequiredService<ILoggerFactory>();