Upgrade System.CommandLine to beta5 (2.0.0-beta5.25306.1)#1267
Upgrade System.CommandLine to beta5 (2.0.0-beta5.25306.1)#1267
Conversation
Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
… changes Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
…edCommand, etc. Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
…arly parsing issues Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Fix all todo's. Address all my comments.
dotnet-install.sh
Outdated
There was a problem hiding this comment.
We don't need this file, let's remove it from the PR
| HelpName = "failure rate" | ||
| }; | ||
|
|
||
| // TODO: Fix validation API for beta5 |
| HelpName = "failure rate" | ||
| }; | ||
|
|
||
| // TODO: Fix validation API for beta5 |
| HelpName = "summary-group-by" | ||
| }; | ||
|
|
||
| // TODO: Fix validation API for beta5 |
DevProxy/Commands/CertCommand.cs
Outdated
| }); | ||
|
|
||
| var certRemoveCommand = new Command("remove", "Remove the certificate from Root Store"); | ||
| certRemoveCommand.SetAction((parseResult) => |
There was a problem hiding this comment.
Simplify to certEnsureCommand.SetAction(RemoveCert)
DevProxy/Commands/DevProxyCommand.cs
Outdated
| HelpName = "ipAddress" | ||
| }; | ||
|
|
||
| // TODO: Fix validation for beta5 |
DevProxy/Commands/DevProxyCommand.cs
Outdated
| } | ||
|
|
||
| _ipAddress = result.GetValueForOption(_ipAddressOption); | ||
| // TODO: Fix early parsing for beta5 - Options no longer have Parse method |
DevProxy/Commands/DevProxyCommand.cs
Outdated
| { | ||
| urlsToWatch = null; | ||
| } | ||
| // TODO: Fix early parsing for beta5 - Options no longer have Parse method |
DevProxy/Commands/DevProxyCommand.cs
Outdated
| Console.Error.WriteLine(error.Message); | ||
| Console.ForegroundColor = color; | ||
| Environment.Exit(1); | ||
| _logLevelOption = new Option<LogLevel?>( |
There was a problem hiding this comment.
If the option doesn't have an alias, you can invoke the constructor with just one argument. No need to pass an empty array. Fix all other occurrences as well.
| // Store options for use in parsing methods | ||
| Options = options.AsReadOnly(); | ||
|
|
||
| // Add log level as a regular option instead of global option |
…dback Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
All System.CommandLine beta5 TODO items have been fixed and all review feedback has been addressed. The implementation includes: ✅ Removed Changes committed in 5582a14. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Move all validation logic to validators like it was, so that the code is centralized and doesn't need to be duplicated each time we read an option's value in the code.
…on validators Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
Validation logic has been moved to centralized option validators. All inline validation code in OptionsLoaded handlers has been replaced with proper validators using the System.CommandLine beta5 Validators.Add() API. This eliminates code duplication and centralizes validation logic for rate options (0-100 range) and env format validation (key=value). Changes committed in 317a2e5. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR upgrades System.CommandLine from
2.0.0-beta4.22272.1to the latest2.0.0-beta5.25306.1across all projects in the solution.Major Breaking Changes Addressed
API Changes
ParseResultinstead of the removedInvocationContextSetActionAPIAddOption/AddCommand→Add,GetValueForOption→GetValueOption Configuration
new Option<T>(name, aliases[])instead of separateAddAlias()callsArgumentHelpName→HelpNamethroughout the codebaseCommand Architecture
SetActionapproach using lambda functionsIList<Option>vsIReadOnlyList<Option>parameter mismatchesSpecific Command Updates
SetHandler→SetAction,AddArgument→Add, fixed Argument constructorTemporary Workarounds
Some advanced features have been temporarily disabled with TODO comments for future enhancement:
Testing
The application should build and run correctly with the new System.CommandLine beta5. Full functional testing recommended to ensure all command-line functionality works as expected.
Fixes #1265.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.mscurl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.