Skip to content

Commit 51337c8

Browse files
Remove COMPLUS_* environment variable references (#5714)
Minimum supported runtime is now .NET 8, so `COMPLUS_*` env var fallbacks are unnecessary — all config uses `DOTNET_*`. - **`ProcessRunner.WithRuntimeConfiguration`**: Remove `COMPlus_` fallback (the existing comment explicitly called for this) - **`documentation/FAQ.md`**: Remove stale note about .NET 6 requiring `COMPlus_` prefix Files in `src/shared/` (`clrconfignocache.h`, `resource.h`) are synced from dotnet/runtime and left unchanged — `BFA_BAD_COMPLUS_SIG` refers to COM+ metadata signatures, not env vars. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/diagnostics/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>
1 parent 553a5f3 commit 51337c8

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

documentation/FAQ.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ Frequently Asked Questions
7373
7474
If that doesn't work, try using the `setclrpath <directory>` command with a directory that contains the matching version of the DAC module. This is useful for private runtimes or debug builds that haven't been published to our symbol servers.
7575
76-
If this is a dump, the problem could also be that the dump is missing some memory required by SOS. Try generating a "full" dump (the default with `dotnet-dump collect` without a `--type` option) or add setting the crash dump generation (createdump) environment variable `DOTNET_DbgMiniDumpType=4` (.NET 6 and below require `COMPlus_` prefix instead of `DOTNET_`). For more details on crash dump generation see [here](https://docs.microsoft.com/en-us/dotnet/core/diagnostics/dumps#collecting-dumps-on-crash).
76+
If this is a dump, the problem could also be that the dump is missing some memory required by SOS. Try generating a "full" dump (the default with `dotnet-dump collect` without a `--type` option) or add setting the crash dump generation (createdump) environment variable `DOTNET_DbgMiniDumpType=4`. For more details on crash dump generation see [here](https://docs.microsoft.com/en-us/dotnet/core/diagnostics/dumps#collecting-dumps-on-crash).
7777
7878
* If you receive this error message executing a SOS command:
7979
```

src/Microsoft.Diagnostics.TestHelpers/ProcessRunner.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,8 @@ public ProcessRunner RemoveEnvironmentVariable(string key)
122122
return this;
123123
}
124124

125-
// Remove COMPlus_ fallback once minimum supported runtime is .NET 8
126125
public ProcessRunner WithRuntimeConfiguration(string key, string value) =>
127-
WithEnvironmentVariable($"DOTNET_{key}", value)
128-
.WithEnvironmentVariable($"COMPlus_{key}", value);
126+
WithEnvironmentVariable($"DOTNET_{key}", value);
129127

130128
public ProcessRunner WithEnvironmentVariable(string key, string value)
131129
{

0 commit comments

Comments
 (0)